AAE-26100 Synchronize process definitions between runtime bundle and query services #1582
+1,119
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igdianov
force-pushed
the
feature/AAE-26100-igdianov-sync-process-definitions
branch
from
41ed994
to
f6186fe
Compare
igdianov
force-pushed
the
feature/AAE-26100-igdianov-sync-process-definitions
branch
2 times, most recently
from
8425434
to
83eba2e
Compare
igdianov
force-pushed
the
feature/AAE-26100-igdianov-sync-process-definitions
branch
2 times, most recently
from
8fd77ff
to
ee44eab
Compare
igdianov
changed the title
igdianov
force-pushed
the
feature/AAE-26100-igdianov-sync-process-definitions
branch
from
fa6c0af
to
71ef9ea
Compare
igdianov
force-pushed
the
feature/AAE-26100-igdianov-sync-process-definitions
branch
from
71ef9ea
to
3daae59
Compare
|
erdemedeiros
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Great job @igdianov ! I like the usage of IntegrationFlows with the auto routing based on enriched headers. Maybe we can evolve the connector starters to use something similar in the future.
I've added only one small question. LGTM, otherwise
| @@ -112,6 +113,7 @@ public void checkProcessInstanceHasVariableValue( | |||
| Object variableValue | |||
| ) { | |||
| await() | |||
| .atMost(Duration.ofSeconds(30)) | |||
There was a problem hiding this comment.
Is this needed? I was expecting the default timeout of 10 seconds to be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of the implementation to add a command executor in the Process Runtime Service core to be able to trigger process definitions sync via a command message sent by the Query service via a batch job. The Process Runtime will handle the synchronization request by sending the process definitions back to Query via existing process deployed audit messages and return execution result to the requestor via command results channel.
Part of https://hyland.atlassian.net/browse/AAE-26100