Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AGW linking #179

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] AGW linking #179

wants to merge 5 commits into from

Conversation

coffeexcoin
Copy link
Collaborator

@coffeexcoin coffeexcoin commented Jan 17, 2025

  • add AGW link actions
  • feat: agw linking
  • fix export

PR-Codex overview

This PR introduces new constants and functionalities related to delegation rights and contract interactions in the agw-client package, enhancing the handling of linked accounts and delegation mechanisms.

Detailed summary

  • Added new constants: BRIDGEHUB_ADDRESS, CANONICAL_DELEGATE_REGISTRY_ADDRESS, CANONICAL_EXCLUSIVE_DELEGATE_RESOLVER_ADDRESS, AGW_LINK_DELEGATION_RIGHTS, and NON_EXPIRING_DELEGATION_RIGHTS.
  • Updated getLinkedAgw function to retrieve linked accounts based on delegation rights.
  • Implemented error handling for invalid addresses in getLinkedAgw functions.
  • Enhanced linkToAgw function to handle linking accounts with new delegation rights.
  • Introduced ExclusiveDelegateResolverAbi and DelegateRegistryAbi to define smart contract interfaces for delegation.
  • Added methods in the BridgeHubAbi and ZkSyncAbi for transaction handling and state management.
  • Updated constants export to include new delegation-related constants.

The following files were skipped due to too many changes: packages/agw-client/src/abis/ZkSyncAbi.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coffeexcoin coffeexcoin requested a review from cygaar as a code owner January 17, 2025 15:39
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: a58948f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 17, 2025

@@ -1,6 +1,8 @@
import AGWAccountAbi from '../abis/AGWAccount.js';
import {
AGW_REGISTRY_ADDRESS,
CANONICAL_DELEGATE_REGISTRY_ADDRESS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also export the BRIDGEHUB_ADDRESS here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants