Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group-prefixes - multiple values at once #73

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

dk1844
Copy link
Collaborator

@dk1844 dk1844 commented Sep 6, 2023

This PR enhances work done in #67, now there are multiple user group prefixes to be requested at once.

Original:

  • POST /token/generate?groups-prefix=just-one-prefix
    Newly:
  • POST /token/generate?group-prefixes=prefix1,prefix2,prefix3.

Added a few tests.

Closes #42

…POST /token/generate?group-prefixes=prefix1,prefix2,prefix`. Tests added
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

JaCoCo code coverage report - scala:2.12.17

File Coverage [100%] 🍏
TokenController.scala 100% 🍏
User.scala 100% 🍏
Total Project Coverage 73.54% 🍏

Copy link
Collaborator

@jakipatryk jakipatryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just checked the code)

@dk1844 dk1844 merged commit bd862c6 into master Sep 11, 2023
3 checks passed
@dk1844 dk1844 deleted the feature/42-filter-groups-multi branch September 11, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups filtering
2 participants