-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add models and interfaces #33
Open
OlivieFranklova
wants to merge
20
commits into
master
Choose a base branch
from
feature/models-and-interfaces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
OlivieFranklova
added
the
work in progress
Work on this item is not yet finished (mainly intended for PRs)
label
Sep 20, 2024
This was
linked to
issues
Oct 2, 2024
Closed
OlivieFranklova
force-pushed
the
feature/models-and-interfaces
branch
2 times, most recently
from
October 2, 2024 13:33
6fae81f
to
fc86dce
Compare
OlivieFranklova
force-pushed
the
feature/models-and-interfaces
branch
from
October 3, 2024 07:42
fc86dce
to
b4469b7
Compare
OlivieFranklova
removed
the
work in progress
Work on this item is not yet finished (mainly intended for PRs)
label
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28 and sub tickets: closes #23 closes #25 closes #26
Upon closer examination, I moved Connectors and User Interfaces to a new package SimilarityRunner. Similarity should only compare two data tables. It could be published into pip as a tool for computing similarity between two tables.So I propose to creating a new repository SimilarityApp (as a better name than Similarity Runner). It will get data, prepare a run for multiple tables, compare all tables, and show output. SimilarityApp will use DatasetSimilarity for computing the similarity between two tables.