Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models and interfaces #33

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

OlivieFranklova
Copy link
Collaborator

@OlivieFranklova OlivieFranklova commented Sep 18, 2024

closes #28 and sub tickets: closes #23 closes #25 closes #26


Upon closer examination, I moved Connectors and User Interfaces to a new package SimilarityRunner. Similarity should only compare two data tables. It could be published into pip as a tool for computing similarity between two tables.
So I propose to creating a new repository SimilarityApp (as a better name than Similarity Runner). It will get data, prepare a run for multiple tables, compare all tables, and show output. SimilarityApp will use DatasetSimilarity for computing the similarity between two tables.

@OlivieFranklova OlivieFranklova self-assigned this Sep 18, 2024
@OlivieFranklova OlivieFranklova linked an issue Sep 18, 2024 that may be closed by this pull request
@OlivieFranklova OlivieFranklova linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1205 944 78% 70% 🟢

New Files

File Coverage Status
similarityRunner/connectors/_init_.py 100% 🟢
similarityRunner/connectors/filesystem_connector.py 100% 🟢
similarityRunner/formators/_init_.py 100% 🟢
similarityRunner/formators/jason_formater.py 100% 🟢
similarityRunner/functions_runner.py 100% 🟢
similarityRunner/interfaces/ConnectorInterface.py 80% 🟢
similarityRunner/interfaces/OutputFormaterInterface.py 100% 🟢
similarityRunner/interfaces/_init_.py 100% 🟢
similarityRunner/models/_init_.py 100% 🟢
similarityRunner/models/connector_models.py 100% 🟢
TOTAL 98% 🟢

Modified Files

File Coverage Status
similarity/Comparator.py 65% 🟢
similarity/ComparatorByColumn.py 81% 🟢
similarity/DataFrameMetadataCreator.py 79% 🟢
similarity/Types.py 90% 🟢
TOTAL 79% 🟢

updated for commit: 628fa79 by action🐍

@OlivieFranklova OlivieFranklova added the work in progress Work on this item is not yet finished (mainly intended for PRs) label Sep 20, 2024
@OlivieFranklova OlivieFranklova marked this pull request as draft September 23, 2024 08:13
@OlivieFranklova OlivieFranklova force-pushed the feature/models-and-interfaces branch 2 times, most recently from 6fae81f to fc86dce Compare October 2, 2024 13:33
@OlivieFranklova OlivieFranklova marked this pull request as ready for review October 4, 2024 09:47
@OlivieFranklova OlivieFranklova removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Models and interfaces Output formater interface File system connector Add user interface
1 participant