Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unite project with team culture #21

Merged
merged 11 commits into from
Sep 18, 2024

Conversation

OlivieFranklova
Copy link
Collaborator

@OlivieFranklova OlivieFranklova commented Sep 16, 2024

  • add CODEOWNERS file
  • add .pylintrc file
  • add Black check to worflow
  • format files with Black

Closes #18

@OlivieFranklova OlivieFranklova self-assigned this Sep 16, 2024
@OlivieFranklova OlivieFranklova linked an issue Sep 16, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 16, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1130 872 77% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
column2Vec/impl/Column2Vec.py 98% 🟢
column2Vec/impl/functions.py 43% 🟢
similarity/Comparator.py 65% 🟢
similarity/ComparatorByColumn.py 81% 🟢
similarity/DataFrameMetadata.py 82% 🟢
similarity/DataFrameMetadataCreator.py 79% 🟢
similarity/Types.py 90% 🟢
similarity/functions.py 0% 🟢
TOTAL 67% 🟢

updated for commit: 3a0ab62 by action🐍

Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pull
  • code review
  • test run - 80 passed, 2 skipped, 500 warnings

From the overall review, I have noted these points (as ideas only):

  • Data and data_validation could be placed in the tests folder where they are used. Then, no repo structure explanation is needed in README.
  • Why mention workflows? The README is for users. The developer will face it in the first PR.
  • Did you think about a command line argument parser to avoid enabling inner features by editing main.py file?
  • In README in How to run, I would expect sub-chapters describing how to reach variant: two variant of similarity and column2vec
  • DataShow looks like three features. I saw only one line in README.
  • I would add some duration value. Maybe an example of the output: 80 passed, 2 skipped, 500 warnings in 1887.83s (0:31:27)
  • Consider a more detailed table of contents for users looking for exact parts.

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/workflows/py_test.yml Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
column2Vec/reaserch/column2Vec_re.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@OlivieFranklova OlivieFranklova mentioned this pull request Sep 17, 2024
@OlivieFranklova
Copy link
Collaborator Author

  • pull
  • code review
  • test run - 80 passed, 2 skipped, 500 warnings

From the overall review, I have noted these points (as ideas only):

  • Data and data_validation could be placed in the tests folder where they are used. Then, no repo structure explanation is needed in README.
  • Why mention workflows? The README is for users. The developer will face it in the first PR.
  • Did you think about a command line argument parser to avoid enabling inner features by editing main.py file?
  • In README in How to run, I would expect sub-chapters describing how to reach variant: two variant of similarity and column2vec
  • DataShow looks like three features. I saw only one line in README.
  • I would add some duration value. Maybe an example of the output: 80 passed, 2 skipped, 500 warnings in 1887.83s (0:31:27)
  • Consider a more detailed table of contents for users looking for exact parts.

@OlivieFranklova OlivieFranklova force-pushed the feature/unite-project-with-team-culture branch from d3ab9db to d2acca5 Compare September 17, 2024 12:08

st.title("Uber pickups in NYC")
DATE_COLUMN = "date/time"
DATA_URL = "https://s3-us-west-2.amazonaws.com/" "streamlit-demo-data/uber-raw-data-sep14.csv.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, this gets concatenated, why have it separate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw

  • 2 skipped tests
  • 500 warnings

Are you planning to zero this indicators.

@OlivieFranklova
Copy link
Collaborator Author

I saw

  • 2 skipped tests
  • 500 warnings

Are you planning to zero this indicators.

I will resolve warnings in future
skipped tests will be resolved in #32

@OlivieFranklova OlivieFranklova merged commit 3399ac2 into master Sep 18, 2024
5 checks passed
@OlivieFranklova OlivieFranklova deleted the feature/unite-project-with-team-culture branch September 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unite project with team culture
3 participants