Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support enums in docs #364

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Support enums in docs #364

merged 9 commits into from
Mar 28, 2024

Conversation

lukasmatta
Copy link
Collaborator

No description provided.

@lukasmatta lukasmatta linked an issue Mar 28, 2024 that may be closed by this pull request
Support enums #362
Closed
@lukasmatta lukasmatta self-assigned this Mar 28, 2024
@lukasmatta lukasmatta added enhancement New feature or request composition labels Mar 28, 2024
@fateeand
Copy link
Collaborator

Missing @group Enums for CpsNotificationType.

CpsColumnFilterMatchMode is ambiguous for now, as it seems like it's not used anywhere according to the docs, but it should be fixed in #350

@lukasmatta
Copy link
Collaborator Author

Missing @group Enums for CpsNotificationType.

CpsColumnFilterMatchMode is ambiguous for now, as it seems like it's not used anywhere according to the docs, but it should be fixed in #350

I didn't add it for the CpsNotificationType enum on purpose, as it is an internal enum not exported by the library, on the other hand, CpsColumnFilterMatchMode is exported.

@lukasmatta lukasmatta merged commit ed66c6b into master Mar 28, 2024
1 check passed
@lukasmatta lukasmatta deleted the 362-support-enums branch March 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fateeand fateeand fateeand approved these changes

@korel-san korel-san Awaiting requested review from korel-san korel-san is a code owner

@TerranceKhumalo-absa TerranceKhumalo-absa Awaiting requested review from TerranceKhumalo-absa TerranceKhumalo-absa is a code owner

@AtlegangMolokwane AtlegangMolokwane Awaiting requested review from AtlegangMolokwane

Assignees

@lukasmatta lukasmatta

Labels
composition enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support enums
2 participants
@lukasmatta @fateeand