Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#42 Add possibility to delete data from table #45

Merged
merged 3 commits into from
Oct 22, 2024
Merged

#42 Add possibility to delete data from table #45

merged 3 commits into from
Oct 22, 2024

Conversation

benedeki
Copy link
Contributor

@benedeki benedeki commented Oct 16, 2024 •
edited
Loading

  • add methods delete to DBTable in several overloaded flavors
  • fixed addNull evaluation bug on DBTable
  • added license entries to testing SQLs
  • DBTable covered by integration tests

Closes #42
Fixes #44

Release Notes

  • DBTable now offers delete operation.
  • addNull parameter now properly works in DBTable.

@benedeki
#42 Add possibility to delete data from table
55213e0 
* add methods `delete` to `DBTable` in several overloaded flavors
* fixed `addNull` evaluation bug on `DBTable`
* added license entries to testing SQLs
* `DBTable` covered by integration tests
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

JaCoCo 'balta' module code coverage report - scala 2.12.18

Overall Project 61.75% 🍏
Files changed 100% 🍏

File Coverage
DBQuerySupport.scala 100% 🍏
DBTable.scala 91.28% 🍏
SetterFnc.scala 29.52% 🍏

miroslavpojer
miroslavpojer reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review
  • run all sbt test command
  • run jacoco

balta/src/main/scala/za/co/absa/db/balta/classes/DBTable.scala Outdated Show resolved Hide resolved
balta/src/test/resources/db/postgres/09_testing.table_lifecycle.ddl Outdated Show resolved Hide resolved
balta/src/test/scala/za/co/absa/db/balta/classes/DBTableIntegrationTests.scala Show resolved Hide resolved
balta/src/test/scala/za/co/absa/db/balta/classes/DBTableIntegrationTests.scala Show resolved Hide resolved
balta/src/test/scala/za/co/absa/db/balta/classes/DBTableIntegrationTests.scala Show resolved Hide resolved
@benedeki benedeki self-assigned this Oct 18, 2024
@benedeki benedeki merged commit 9d216c2 into master Oct 22, 2024
9 of 12 checks passed
@benedeki benedeki deleted the feature/42-add-possibility-to-delete-data-from-table branch October 22, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@lsulak lsulak Awaiting requested review from lsulak lsulak is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees

@benedeki benedeki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using addNull param on DBTable it is nto evaluated correctly Add possibility to delete data from table
2 participants
@benedeki @miroslavpojer