Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality for command classes #203

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

sdevih
Copy link

@sdevih sdevih commented Apr 15, 2024

  • Code documentation was added to some methods in the LogAdd, LogEdit and LogDelete classes.
  • Variable names were refactored to maximise readability.
  • Redundant parameter in the method getLatestLogId in LogDelete command class was removed.

All changes were made in adherence to the v1.4 milestone where improvement of code quality is allowed.

sdevih added 2 commits April 15, 2024 19:24
Documentation was added to some methods in the logadd, logedit and
logdelete classes. Variable names were refactored to maximise readability.
@sdevih sdevih requested a review from a team April 15, 2024 11:35
Copy link

@soons1 soons1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@gerteck gerteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soons1 soons1 merged commit f37dcd2 into AY2324S2-CS2103T-T09-3:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants