Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DG use cases and add planned enhancement for duplicate detection. #201

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Update DG use cases and add planned enhancement for duplicate detection. #201

merged 9 commits into from
Apr 15, 2024

Conversation

CJerrong
Copy link

@CJerrong CJerrong commented Apr 15, 2024 •
edited
Loading

  • Add use cases for edit, logedit, undo and redo
  • Refactor use cases in DG to omit mechanical details like the use of index
  • Add planned enhancement for better duplicate detection, to warn users when inputting similar values with minor variations like extra white spacings.
  • Add in page break formatting for DG
  • Fix typos in DG

@CJerrong CJerrong requested review from soons1 and gerteck April 15, 2024 06:09
@CJerrong CJerrong added this to the v1.4 milestone Apr 15, 2024
gerteck
gerteck approved these changes Apr 15, 2024
View reviewed changes
Copy link

@gerteck gerteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

But don't merge yet, can add the page breaks before merging

@gerteck gerteck mentioned this pull request Apr 15, 2024
Closed
soons1
soons1 reviewed Apr 15, 2024
View reviewed changes
Copy link

@soons1 soons1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chaaaaun chaaaaun merged commit 5eb9f85 into AY2324S2-CS2103T-T09-3:master Apr 15, 2024
3 checks passed
sdevih
sdevih reviewed Apr 15, 2024
View reviewed changes
Copy link

@sdevih sdevih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdevih sdevih sdevih left review comments

@soons1 soons1 soons1 left review comments

@gerteck gerteck gerteck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Elder Scrolls
Status: Done
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@CJerrong @soons1 @gerteck @sdevih @chaaaaun