Merge pull request #207 from CJerrong/fix-logAdd

Fix exception messages displaying wrong information
AY2324S2-CS2103T-T09-3 · Apr 15, 2024 · dfdb87d · dfdb87d
2 parents ead3de5 + 41539d4
commit dfdb87d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/scrolls/elder/logic/commands/LogAddCommand.java b/src/main/java/scrolls/elder/logic/commands/LogAddCommand.java
@@ -49,7 +49,7 @@ public class LogAddCommand extends Command {
         + PREFIX_REMARKS + "was a good session ";
 
     public static final String MESSAGE_SUCCESS = "New log added!";
-    public static final String MESSAGE_NEGATIVE_DURATION = "Duration cannot be negative.";
+    public static final String MESSAGE_NEGATIVE_DURATION = "Duration must be positive.";
     public static final String MESSAGE_PERSONS_NOT_PAIRED = "The volunteer and befriendee are not paired.";
 
     /**

diff --git a/src/main/java/scrolls/elder/logic/commands/LogEditCommand.java b/src/main/java/scrolls/elder/logic/commands/LogEditCommand.java
@@ -54,7 +54,7 @@ public class LogEditCommand extends Command {
 
     public static final String MESSAGE_EDIT_LOG_SUCCESS = "Edited Log successfully: %1$s";
     public static final String MESSAGE_NOT_EDITED = "At least one field to edit must be provided.";
-    public static final String MESSAGE_NEGATIVE_DURATION = "Duration cannot be negative.";
+    public static final String MESSAGE_NEGATIVE_DURATION = "Duration must be positive.";
 
     private final Index index;
     private final EditLogDescriptor editLogDescriptor;

diff --git a/src/main/java/scrolls/elder/logic/parser/ParserUtil.java b/src/main/java/scrolls/elder/logic/parser/ParserUtil.java
@@ -173,7 +173,7 @@ public static Integer parseInt(String num) throws ParseException {
         try {
             return Integer.parseInt(trimmedNum);
         } catch (NumberFormatException e) {
-            throw new ParseException("Invalid number format. Expected a number.", e);
+            throw new ParseException("Invalid number format. Expected an integer.", e);
         }
     }
 }
diff --git a/src/test/java/scrolls/elder/logic/parser/LogAddCommandParserTest.java b/src/test/java/scrolls/elder/logic/parser/LogAddCommandParserTest.java
@@ -52,7 +52,7 @@ public void parse_invalidDateFormat_throwsParseException() {
     @Test
     public void parse_invalidDurationFormat_throwsParseException() {
         assertParseFailure(parser, "1 2 t/Movies s/2024-03-07 d/Two r/Good",
-                "Invalid number format. Expected a number.");
+                "Invalid number format. Expected an integer.");
     }
 
     @Test

diff --git a/src/test/java/scrolls/elder/logic/parser/LogEditCommandParserTest.java b/src/test/java/scrolls/elder/logic/parser/LogEditCommandParserTest.java
@@ -80,7 +80,7 @@ public void parse_invalidDateFormat_throwsParseException() {
     @Test
     public void parse_invalidDurationFormat_throwsParseException() {
         assertParseFailure(parser, "1 t/Icebreaker s/2024-04-08 d/Two r/Was okay.",
-                "Invalid number format. Expected a number.");
+                "Invalid number format. Expected an integer.");
     }
     @Test
     public void parse_invalidArgs_throwsParseException() {