Skip to content

Commit

Permalink
Merge pull request #341 from ShiJiaAo/master
Browse files Browse the repository at this point in the history
Update DG and small printing errors
  • Loading branch information
ShiJiaAo authored Apr 10, 2023
2 parents 05c29f0 + 786d550 commit 49479c2
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
22 changes: 11 additions & 11 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,18 +275,9 @@ The following sequence diagram summarizes the interaction of classes when the co

<img src="images/DeleteStudentSequenceDiagramWithoutReturns.png" />

#### Design considerations:

**Aspect: How the command input is structured**

* **Alternative 1 (current choice):** Chooses the student index from a list of students in the event.
* Pros: Easier for TA to refer to.
* Cons: More difficult to implement as student index reference needs to be changes.

* **Alternative 2:** Choose the student index from the list of students in the student tab.
* Pros: Easier to implement since same student index reference can be used.
* Cons: More troublesome for the TA since changing of tabs needs to be done to find the student index.
#### Possible Updates

Support could be added for the command to take in more student index fields, so that the TA may delete multiple students at once without needing to keep re-entering the same command.

### Help feature

Expand Down Expand Up @@ -1088,3 +1079,12 @@ Given below are our planned enhancements.

- As of now, the student table is not optimized for long data. When the window is minimized, the student data is not centered horizontally and vertically in each cell.
We can simply add cosmetic changes in the fxml file to center the student data horizontally and vertically in each cell.

- As of now, the performance indicator (a score of 0 to 100), is as descriptive of a student's performance in class as it can be.
In future iterations, we planned to add more descriptive performance fields, like examination and assignment scores.

- The current way of entering performance scores is quite troublesome for the TA. In future enhancements, performance scores in various aspects (like assignment or examination grades)
can be automatically imported or read from Canvas or any other learning management system used by the university.

- The current way of adding students into the student list is also quite troublesome. In future enhancements, they can be automatically parsed from a class list
from canvas or any other learning management system used by the university.
2 changes: 1 addition & 1 deletion docs/team/shijiaao.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ title: Jia Ao's Project Portfolio Page

### Project: TrAcker

TrAcker - TrAcker is a desktop event management application for NUS CS2040 Teaching Assitants (TA). The user interacts with it using a CLI, and it has a GUI created with JavaFX. It is written in Java.
TrAcker - TrAcker is a desktop event management application for NUS CS2040 Teaching Assistants (TA). The user interacts with it using a CLI, and it has a GUI created with JavaFX. It is written in Java.

Given below are my contributions to the project.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class AddStudentToEventCommand extends Command {
+ "event type or the event type that you have entered "
+ "cannot be recognized!\n";
public static final String MESSAGE_STUDENT_INDEX_TOO_BIG = "The student index you have entered cannot be bigger "
+ "than the size of the student list within the event";
+ "than the size of the student list";
public static final String MESSAGE_STUDENT_INDEX_INVALID = "The student index "
+ "needs to be a single non-zero integer!";
public static final String MESSAGE_EVENT_INDEX_TOO_BIG = "The event index you have entered cannot be "
Expand Down

0 comments on commit 49479c2

Please sign in to comment.