Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 38 changes #49

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Issue 38 changes #49

merged 2 commits into from
Jan 23, 2024

Conversation

JacobHomanics
Copy link

@JacobHomanics JacobHomanics commented Jan 23, 2024

Changes referenced from: Issue 38

  • DAO Name: ATX Nouns (completed as long as this means the same thing as NFT collection name)
  • DAO Symbol: $ATX (completed as long as this means the same thing as NFT collection symbol)
  • Auction duration: 3 days (hold off on setting this one until launch so we can keep it short during testing)
  • Auction reserve price: 0.00512 ETH
  • Name of the NFT displayed in the Auction UI should be "ATX Noun #"
  • Replace "Nouns" with "ATXNouns" in all of the contract names (Will require some big changes that are worthy of creating a seperate issue and PR).

The contracts HAVE NOT been redeployed as @spatializes is more familiar with the process so I will let him take the reins on doing so. Thus, even though these changes have been made on the repository, it may not fully reflect what you see until we actually do the full redeployment process.

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
member-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 7:30pm

@willyogo
Copy link
Member

overall looks great, but noticing that the auction page no longer displays the correct # of the atx noun and instead displays {0} for each nft.

image

AC:

  1. the correct # is displayed for each noun on the auction page

@willyogo willyogo merged commit 3a55c42 into master Jan 23, 2024
2 checks passed
@willyogo willyogo deleted the github-issue-38 branch January 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants