-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V10 helper func #97
base: develop
Are you sure you want to change the base?
V10 helper func #97
Conversation
helper function provided by the nordic sdk
found in nordic sdk v10
@@ -25,7 +25,7 @@ | |||
], | |||
"dependencies": { | |||
"ble": "^2.1.16", | |||
"nrf51-sdk": "^1.0.0" | |||
"nrf51-sdk": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LiyouZhou: There seems to be a conflict with this PR, I think the problem is that the required nordic sdk version has already been updated in develop for this module.
bump |
I didn't forgot about these, it is just that I need time to analyze what is going on on the previous implementation and the new one. |
how's this gonna go now that there's an nrf52 sdk module? |
Automatic CI verification build not done, please verify manually. |
NRF52 doesn't change anything, the Nordic SDK still exist, softdevice still exist and NRF51 still exist. |
sure, but there's a direct dependency on the nrf51 sdk yotta module, but no dependency on the nrf52-sdk yotta module |
The nrf52 port is far from ready at the moment. |
@pan- What is your plan for this? |
I won't merge it now, I need time to understand all the implications of this change. But I did not forget about it. |
Replace helper functions provided by ble-nrf51822 with ones provided by nordic sdk v10. Depends on ARMmbed/nrf51-sdk#13.
@pan- Please review.