Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Function update_one cannot accept CanonicalPathBuf for deleted files #45

Closed
kirillt opened this issue Sep 20, 2023 · 1 comment · Fixed by #57
Closed

Function update_one cannot accept CanonicalPathBuf for deleted files #45

kirillt opened this issue Sep 20, 2023 · 1 comment · Fixed by #57
Assignees
@Rizary
Labels
bug Something isn't working

Comments

@kirillt
Copy link
Member

kirillt commented Sep 20, 2023 •
edited
Loading

This is an oversight of implementation in #42

See #38 for more context. TL;DR: We use update_one for cases when a resource by some path changed or was deleted at all. We can't canonicalize a non-existent path, so we fail to call update_one in this case. This API should receive plain Path-like type: Path, PathBuf or be generic with AsRef<Path>.
@kirillt kirillt added the bug Something isn't working label Sep 20, 2023
@kirillt kirillt moved this to Todo in Development Oct 15, 2023
@kirillt
Copy link
Member Author

kirillt commented Oct 18, 2023

This is necessary for this PR:

@kirillt kirillt moved this from Todo to In Progress in Development Oct 21, 2023
@kirillt kirillt assigned Rizary and unassigned mberry Oct 23, 2023
@Rizary Rizary mentioned this issue Nov 4, 2023
Merged
kirillt pushed a commit that referenced this issue Nov 16, 2023
@Rizary
#45: Change the parameter's type of update_one to generic Path (#57)
9b36e5e 
* change update_one parameter to path and implement its test
* add public `forget_id` for removals without knowing the path
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Nov 16, 2023
@kirillt kirillt mentioned this issue Nov 16, 2023
Open
@kirillt kirillt assigned Rizary and unassigned Rizary Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Rizary Rizary

Labels
bug Something isn't working
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#45: Change the parameter's type of update_one to generic Path ARK-Builders/arklib
3 participants
@kirillt @Rizary @mberry