Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#27: Handle absence of the folder #29

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

#27: Handle absence of the folder #29

wants to merge 5 commits into from

Conversation

mdrlzy
Copy link
Member

@mdrlzy mdrlzy commented Jul 27, 2023 •
edited by kirillt
Loading

@kirillt
Copy link
Member

kirillt commented Jul 28, 2023 •
edited
Loading

  • Integrate ACRA

When there is no folder:

  • Attempt to save link must result in an alert
  • User should be aware that absence of links is caused by absence of the folder

When there is invalid path specified:

  • User should be informed that the path is wrong
  • User should be suggested to select the path again

Verify

  • Saving links into correct folder works
  • Reading links from the correct folder works

@mdrlzy mdrlzy force-pushed the 27-handle-absence-of-link-folder branch from 9fcc476 to 8ff541a Compare July 30, 2023 15:10
@mdrlzy mdrlzy temporarily deployed to Development July 30, 2023 19:02 — with GitHub Actions Inactive
@mdrlzy mdrlzy requested a review from kirillt July 31, 2023 18:40
@kirillt kirillt temporarily deployed to Development August 1, 2023 17:29 — with GitHub Actions Inactive
@kirillt
Copy link
Member

kirillt commented Aug 1, 2023

If we take an existing folder and try to open it, the app crashes.

Meta and previews for existing links are not generated, only for new ones.

ACRA doesn't suggest the report dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillt kirillt Awaiting requested review from kirillt

At least 1 approving review is required to merge this pull request.

Assignees

@mdrlzy mdrlzy

Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdrlzy @kirillt