Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5: Integrate the app with Tauri framework #6

Merged
merged 7 commits into from
Mar 16, 2024
Merged

#5: Integrate the app with Tauri framework #6

merged 7 commits into from
Mar 16, 2024

Conversation

alvinosh
Copy link
Collaborator

@alvinosh alvinosh commented Mar 12, 2024 •
edited by kirillt
Loading

prokawsar
prokawsar reviewed Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@prokawsar prokawsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirillt @alvinosh
I think icons can be updated if we have any icons now.
Other than integration looks fine.

svelte.config.js Show resolved Hide resolved
kirillt
kirillt approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@kirillt kirillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alvi!

@kirillt kirillt changed the title Completed Tauri Integration #5: Integrate the app with Tauri framework Mar 16, 2024
@kirillt
Copy link
Member

kirillt commented Mar 16, 2024

@prokawsar we don't have icons yet, thanks for the idea.

@kirillt kirillt mentioned this pull request Mar 16, 2024
Closed
@kirillt kirillt merged commit 265b60a into main Mar 16, 2024
1 check passed
@kirillt
Copy link
Member

kirillt commented Mar 16, 2024

Follow-up issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prokawsar prokawsar prokawsar left review comments

@kirillt kirillt kirillt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvinosh @kirillt @prokawsar