Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iroh Integration Prototype #1

Merged
merged 45 commits into from
Sep 9, 2024
Merged

Conversation

alvinosh
Copy link
Collaborator

No description provided.

@alvinosh alvinosh marked this pull request as ready for review May 31, 2024 13:00
core/src/lib.rs Outdated Show resolved Hide resolved
@kirillt kirillt requested a review from tareknaser June 23, 2024 09:09
Copy link
Collaborator

@tareknaser tareknaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. This is a great start. The code is very clear, and we can definitely build on this

core/src/lib.rs Outdated Show resolved Hide resolved
core/src/lib.rs Show resolved Hide resolved
core/Cargo.toml Outdated Show resolved Hide resolved
core/src/lib.rs Outdated Show resolved Hide resolved
core/src/lib.rs Outdated Show resolved Hide resolved
src-tauri/Cargo.toml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@kirillt kirillt requested a review from shubertm June 30, 2024 08:26
Copy link
Member

@shubertm shubertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20240701_213000
This is the output am getting on Linux, and @alvinosh could you tell how to build for Android or if you have apk

UNIFFI Bindings For Core Library
Copy link
Collaborator

@tareknaser tareknaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you

I've left some comments. Feel free to ignore any that begin with 'nit'—they're just minor suggestions.

core/src/lib.rs Show resolved Hide resolved
core/src/lib.rs Show resolved Hide resolved
README.md Show resolved Hide resolved
core/src/erorr.rs Outdated Show resolved Hide resolved
core/src/lib.rs Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
core/src/erorr.rs Outdated Show resolved Hide resolved
core/src/erorr.rs Outdated Show resolved Hide resolved
core/src/erorr.rs Outdated Show resolved Hide resolved
@shubertm
Copy link
Member

shubertm commented Aug 10, 2024

@shubertm has the connection refused error been resolved? If all works fine, please put QA passed label.

Yeah, this is fixed. The actual sending of files, I can't do now because mobile isn't working
Screenshot_20240810_120437

@kirillt
Copy link
Member

kirillt commented Aug 12, 2024

@alvinosh please resolve comments by addressing or creating follow-up issues, and add couple of lines about the debug mode in README.

core/src/lib.rs Outdated Show resolved Hide resolved
@kirillt
Copy link
Member

kirillt commented Aug 18, 2024

Something happened to .pkg installer.. .dmg looks working

Copy link
Collaborator

@tareknaser tareknaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The code is clear and works exactly as expected.

src/routes/transfers/+page.svelte Outdated Show resolved Hide resolved
src/routes/transfers/send/+page.svelte Outdated Show resolved Hide resolved
</button>
</div>
<div class="flex flex-col gap-2">
<span class="font-semibold">Enter Ticket:</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the receiving side, entering a completely invalid ticket doesn't show an error to the user. The flow continues as if everything is fine, and the user can keep receiving.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not want to show users that the ticket is invalid too quickly, this is to try and stop people from trying to guess and check hashes, so the page to show the confirmation is set later. Maybe this can be reconsidered, but again, I would rather do it in a another pr.

src/routes/transfers/transferring/+page.svelte Outdated Show resolved Hide resolved
core/src/lib.rs Outdated Show resolved Hide resolved
@alvinosh alvinosh merged commit c2f21db into main Sep 9, 2024
4 checks passed
@kirillt kirillt mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants