-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iroh Integration Prototype #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. This is a great start. The code is very clear, and we can definitely build on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the output am getting on Linux, and @alvinosh could you tell how to build for Android or if you have apk
UNIFFI Bindings For Core Library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you
I've left some comments. Feel free to ignore any that begin with 'nit'—they're just minor suggestions.
…com/ARK-Builders/ARK-Drop-Desktop into alvinosh/iroh-integration-prototype
Yeah, this is fixed. The actual sending of files, I can't do now because mobile isn't working |
@alvinosh please resolve comments by addressing or creating follow-up issues, and add couple of lines about the debug mode in |
Something happened to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The code is clear and works exactly as expected.
</button> | ||
</div> | ||
<div class="flex flex-col gap-2"> | ||
<span class="font-semibold">Enter Ticket:</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the receiving side, entering a completely invalid ticket doesn't show an error to the user. The flow continues as if everything is fine, and the user can keep receiving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to show users that the ticket is invalid too quickly, this is to try and stop people from trying to guess and check hashes, so the page to show the confirmation is set later. Maybe this can be reconsidered, but again, I would rather do it in a another pr.
No description provided.