Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Three #18

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update Three #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4930e25
Update to v0.3.0
ma2yama Sep 24, 2024
9f70d00
Run npm audit fix
ma2yama Sep 24, 2024
83b6afd
Update Three.js
ma2yama Sep 25, 2024
61d6906
Set the type of matrix.elements
ma2yama Sep 25, 2024
c6d6cac
Fix import error in THREE
ma2yama Sep 25, 2024
a6cb109
Specify the type for the EventDispatcher
ma2yama Sep 25, 2024
aeb1d1f
Run npm run build-ts
ma2yama Sep 25, 2024
c415bed
exampli-ts also update packages
ma2yama Sep 30, 2024
4390be9
Run npm run build-ts on exampli-ts as well
ma2yama Sep 30, 2024
4927ffd
Don't use three.min.js because it's a different version
ma2yama Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/ar.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions example-ts/basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<title>AR.js-threejs basic example with Typescript</title>
</head>
<body>
<script src="js/three.min.js"></script>
<script src="dist/bundle.js"></script>
<!-- <script src="js/three.min.js"></script> -->
<script src="dist/bundle.js"></script>
</body>
</html>
3 changes: 2 additions & 1 deletion example-ts/dist/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

271 changes: 137 additions & 134 deletions example-ts/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions example-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
"license": "ISC",
"devDependencies": {
"@types/node": "^18.15.11",
"@types/three": "^0.150.1",
"@types/three": "^0.168.0",
"ts-loader": "^9.5.1",
"typescript": "^5.4.3",
"webpack": "^5.91.0",
"webpack-cli": "^5.1.4"
},
"dependencies": {
"@ar-js-org/ar.js-threejs": "../",
"three": "^0.150.1"
"three": "^0.168.0"
}
}
10 changes: 1 addition & 9 deletions example-ts/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ module.exports = (env, argv) => {
extensions: [".tsx", ".ts", ".js"],
},
module,
externals: {
three: {
commonjs: 'three',
commonjs2: 'three',
amd: 'three',
root: 'THREE' // indicates global variable
}
}
}
];
};
};
Loading