-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Backends (Oracle, Stardog, Neo4j) #86
base: develop
Are you sure you want to change the base?
Additional Backends (Oracle, Stardog, Neo4j) #86
Conversation
…d by the SPARQL plugin (via SPARQL query) (#42)
…e query conditions do not match (#42)
…does not work properly (#42)
…turn the correct triple count (it might have been better to use FILTERs); delete requests are now always passed to the underlying client, which also counts the effected triples during delete (#42)
This reverts commit 50ccb7d. According to the documentation of \Erfurt_Ac_Default::areModelsAllowed(), the previous return value was correct. \Erfurt_StoreIntegrationTest::testGetImportsClosureMultipleCallsWithDifferentParameters() fails (at least with Virtuoso) in line 219 when always true is returned as suggested by 50ccb7d.
…is now managed by Composer
…ilures in case of changes in the behavior of the test framework
…s as if many PHP versions do not define the charset per default
…nc_with_aksw Conflicts: Makefile
…ges in aksw/develop
@Matthimatiker: First of all, thanks for the massive work you have done! We will look into this and try to merge it as soon as possible. There are maaaany commits, could you please give us a short summary, what all these are about? Thanks in advance. |
Or maybe a squashed commit resp. quashed commits focused on a topic/problem would be cool |
@Matthimatiker: We will look into this pull request very soon. Could you please give me the rights to push to this branch of your fork? Thanks in advance! |
Separate commits to own branchI created a new branch named apply_pullrequest_86_matthimatiker and applied the latest state of @Matthimatiker's files to it. Further changes besides adaptersBesides the new adapters for Neo4J, Stardog and Oracle, there are also changes concerning composer-integration and further integration tests. Output of make test commandRunning Output
|
Branch apply_pullrequest_86_matthimatiker contains a cleaned up and tested version of Erfurt. Besides the files of Matthimatiker, it also contains feature/php-composer branch content. |
This Pull Request adds support for the following Triple Stores:
A Connector abstraction layer is introduced to allow adding new backends with minimal effort.
It uses several helper classes to hook into the existing Adapter layer:
Generic Connector test cases are provided to simplify adding new Stores.
Additionally, benchmarks (modeled with Athletic) are included. These are useful for optimization and Store comparison.
A Travis CI configuration was added to run unit tests and MySQL integration tests with several PHP versions. You might want to activate the corresponding WebHook for your repository to keep this integration. If you do not need it, then delete the configuration file
.travis.yml
.The system relies on the Dependency Manager Composer to install its used libraries. Therefore, you might want to register Erfurt at Packagist to ensure that anybody can install it via Composer without further configuration.