Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug fixes - embed, streaming response, request retry rename #206

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

miri-bar
Copy link
Contributor

@miri-bar miri-bar commented Aug 25, 2024

  • Allow positional argument in EmbedResult for backward compatibility
  • Handle streaming response for non-200 status code
  • Rename _request function to avoid mypy redefinition error

@miri-bar miri-bar requested a review from pazshalev August 25, 2024 14:13
@github-actions github-actions bot added the lgtm Looks Good to Me label Aug 25, 2024
@github-actions github-actions bot added size:m and removed size:s labels Aug 25, 2024
@miri-bar miri-bar changed the title fix: allow positional argument in EmbedResult for backward compatibility fix: Bug fixes - embed and streaming response Aug 25, 2024
@github-actions github-actions bot added size:l and removed size:m labels Aug 26, 2024
@miri-bar miri-bar changed the title fix: Bug fixes - embed and streaming response fix: Bug fixes - embed, streaming response, request retry rename Aug 26, 2024
@miri-bar miri-bar merged commit 882de79 into main Aug 26, 2024
31 checks passed
@miri-bar miri-bar deleted the embedding_backward_comp branch August 26, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks Good to Me size:l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants