Update tests (issue #76)

[yolaj-nhs]

Improve the tests by doing the following:

• Test the contents of the attribute inference attack in test_attribute_inference_attack.py
• In test_generate_report.py - test for the contents of the generated file (not just whether they pass/fail)
• In test_metrics.py - check the results of the calculation, not just pass/fail
• Remove test_safekeras.old
• The GenerateJSON module is tested inside other tests, which would make things very unclear if there was a failure. Refactor this so the tests are happening in the right place
• test_lira_target should be cleaned after tests
• Removing aisdc/safemodel/classifiers/dp_svc.py warning
• Cleaning files that have been created in tests

Any suggestions of other improvements that could be made to the tests are welcome, and can also be added to the following ticket:

#76

[codecov]

Codecov Report

Merging #205 (3a4e35b) into development (f9e92b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development     #205   +/-   ##
============================================
  Coverage        99.55%   99.55%           
============================================
  Files               39       39           
  Lines             5137     5179   +42     
============================================
+ Hits              5114     5156   +42     
  Misses              23       23           

Files Changed	Coverage Δ
tests/test_worst_case_attack.py	100.00% <ø> (ø)
aisdc/safemodel/classifiers/dp_svc.py	100.00% <100.00%> (ø)
tests/test_attack_report_formatter.py	100.00% <100.00%> (ø)
tests/test_attribute_inference_attack.py	100.00% <100.00%> (ø)
tests/test_failfast.py	100.00% <100.00%> (ø)
tests/test_lira_attack.py	100.00% <100.00%> (ø)
tests/test_metrics.py	99.17% <100.00%> (+0.08%)	⬆️
tests/test_multiple_attacks.py	100.00% <100.00%> (ø)
tests/test_safekeras2.py	100.00% <100.00%> (ø)
tests/test_safemodel.py	100.00% <100.00%> (ø)

[rpreen]

This looks good.

While you're on this, could you also fix the annoying warning (which I know is not directly coming from the tests) that's been there for ages?

aisdc/safemodel/classifiers/dp_svc.py:137: RuntimeWarning: divide by zero encountered in double_scalars
    self.dpsvc_gamma = 1.0 / np.sqrt(

[rpreen]

This PR has a few merge conflicts now that need to be addressed because of changes in other PRs.

[simonrnss]

Great -- just added comments where I found hard-coded directory separators...

[simonrnss]

Sorry - vague comments...I'd prefer not to hard-code /, but I'm not sure if the is.dir will work without it? So, feel free to leave them if it's an issue.

[yolaj-nhs]

This PR has a few merge conflicts now that need to be addressed because of changes in other PRs.

Merge conflicts have been resolved

Merge conflicts have been resolved