Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move maxtext docker images being built to artifact registry #904

Open
parambole opened this issue Sep 20, 2024 · 1 comment
Open

Move maxtext docker images being built to artifact registry #904

parambole opened this issue Sep 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@parambole
Copy link
Collaborator

parambole commented Sep 20, 2024 •
edited
Loading

Currently we are using gcr.io to store the docker images being generated ref: https://github.com/google/maxtext/blob/main/.github/workflows/build_and_upload_images.sh#L51

But with gcr.io being deprecated. We should move to Artifact Registry.
@parambole parambole added the enhancement New feature or request label Sep 20, 2024
@parambole parambole mentioned this issue Sep 20, 2024
Merged
4 tasks
@SauravMaheshkar
Copy link

Might I also suggest moving all *.Dockerfile to some docker/ dir. Might be a little pedantic but it's better code organisation and makes browsing easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parambole @SauravMaheshkar