React rendering #74

SupritBehera · 2021-07-17T09:08:04Z

Proposed changes

Fixes issue #73
Landing, Teams, Events and Blog page integrated

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
[x ] Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Work in progress.

The animations on any of the pages (such as the think animation on the landing page) do not work.
The omission of the Cruip external CSS stylesheet CDN results in the Events and Projects page not looking as expected.
Yet to integrate Projects page
The modal on Events page does not work on Firefox (on the static /theme file for the Events page as well), frontend team needs to work on that

Does not work as expected. While the stylesheet is not applied to landing and teams, but when the events page is opened, it then seems to be applied globally. Furthermore, there's a dark background applied for some reason

…ebsite into react-rendering

specter25

cc @SupritBehera i have reviewed the PR . Just some minor fixes . Rest looks great . I believe there must be some eslint warnings when you run the code , do fix them as well .

Also the commit messages should have only the first word with a capital initial , rest of the message should be in lower case .

specter25 · 2021-07-18T07:02:07Z

client/src/components/team/Team.js

-                  <i className="fa fa-twitter" />
-                </p>
+              <div className="slick-slide">
+                <img src="./images/face6.png" />


Add alt tag to images throughout the code .

These were hardcoded img tags, so had not changed them. Will ensure the alt tags are there in the component that would have the code to display a team member card given its properties and details. Have added alt tags in the few img tags throughout the project (other than Teams page) that didn't have alt tags.

specter25 · 2021-07-18T07:03:26Z

client/src/components/team/Team.js

@@ -1,175 +1,173 @@
 import React from 'react';
-import landscape from '.././images/landscape.jpg';
+


remove this blank line to make the code consistent

specter25 · 2021-07-18T07:03:57Z

client/src/components/navbar/Navbar.js

@@ -1,57 +1,59 @@
 import React from 'react';
-import logo from '.././images/logo.svg';
+import { Link } from 'react-router-dom';
+


remove this blank line

specter25 · 2021-07-18T07:05:05Z

client/src/components/navbar/Navbar.js

+            </li>
+          </ul>
+        </div>
+      </nav>
    </div>
  );
 };


you haven't exported this component .. any specific reason ?

I'm not sure I understand, I have exported the Navbar component in line 61 in Navbar.js with export default Navbar

specter25 · 2021-07-18T07:06:53Z

client/src/components/blogs/Blogs.js

+
+const Blogs = () => {
+  return (
+    <div>


prefer wrapping the contents of components inside a react fragment as the parent tag (In all the components )

…ebsite into react-rendering

SupritBehera added 25 commits July 12, 2021 20:29

Fix relative image paths

f64a72f

Replace App.css with latest CSS code

7943b54

Add Teams page HTML code coverted to JSX

e1287f0

Fix fonts on teams page

5c59997

Update carousel.js

150d996

Add evan.js and think.js

08eda65

Update Footer component

4ade83a

Update NavBar component

5a10ed3

Add routes to navbar component

4a5f7fc

Render Navbar and Footer component in App.js

e3c33b0

Add CDNs to index.html

45e6a5a

Add Landing Page code to client

e208b73

Clean up client/index.html

80c92bf

Add events page to client and route to it

bfc914f

Update image links to CDN in Events page

ea9b73f

Add styled-components to project

2443805

Add styled-component for cruip external CDN CSS stylesheet

f887186

Does not work as expected. While the stylesheet is not applied to landing and teams, but when the events page is opened, it then seems to be applied globally. Furthermore, there's a dark background applied for some reason

Merge branch 'master' of https://github.com/ACM-Thapar/ACM-official-w…

c423017

…ebsite into react-rendering

Merge branch 'master' of https://github.com/ACM-Thapar/ACM-official-w…

4af6bb6

…ebsite into react-rendering

Comment out cruip external CSS stylesheet CDN

99c2696

Change landing page route from /landing to /

9b2b0c9

Clean up code

ca31f83

Change Landing.js from class based to functional component

1d6c997

Add blogs page and route

d042e98

Add margin to blogs page between the footer and blog card area

5adeee7

specter25 requested changes Jul 18, 2021

View reviewed changes

SupritBehera added 4 commits July 20, 2021 14:41

Add alt tags to images

1fd2e73

Remove blank line

d2781fa

Remove blank line from navbar

0b94bb0

Change enclosing divs to fragments in all components

5ee5b84

Merge branch 'master' of https://github.com/ACM-Thapar/ACM-official-w…

c15d0b0

…ebsite into react-rendering

SupritBehera requested a review from specter25 August 18, 2021 07:40

specter25 merged commit bc61918 into ACM-Thapar:master Aug 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React rendering #74

React rendering #74

SupritBehera commented Jul 17, 2021 •

edited

Loading

specter25 left a comment •

edited

Loading

specter25 Jul 18, 2021

SupritBehera Jul 20, 2021

specter25 Jul 18, 2021

specter25 Jul 18, 2021

specter25 Jul 18, 2021

SupritBehera Jul 20, 2021

specter25 Jul 18, 2021

		@@ -1,175 +1,173 @@
		import React from 'react';
		import landscape from '.././images/landscape.jpg';

React rendering #74

React rendering #74

Conversation

SupritBehera commented Jul 17, 2021 • edited Loading

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

specter25 left a comment • edited Loading

Choose a reason for hiding this comment

specter25 Jul 18, 2021

Choose a reason for hiding this comment

SupritBehera Jul 20, 2021

Choose a reason for hiding this comment

specter25 Jul 18, 2021

Choose a reason for hiding this comment

specter25 Jul 18, 2021

Choose a reason for hiding this comment

specter25 Jul 18, 2021

Choose a reason for hiding this comment

SupritBehera Jul 20, 2021

Choose a reason for hiding this comment

specter25 Jul 18, 2021

Choose a reason for hiding this comment

SupritBehera commented Jul 17, 2021 •

edited

Loading

specter25 left a comment •

edited

Loading