Switch to the Kermit logging library #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A LoggerFactory for phoenix has been created, and a SLF4J writer has been added for android. This change is mostly naming, to make the diff from kodein-log smaller. Also use extension methods defined in lightning-kmp.
This log writer requires a patch in kermit. See touchlab/Kermit#381 for details. Also, the OSLog system is bugged anyway, so it should not be used, until Apple releases a fix.
robbiehanson
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the logging utility from kodein-log to kermit. See ACINQ/lightning-kmp#593 for the similar changes in lightning-kmp.
Writing logs to file
With the upgrade to Kotlin 1.9, we removed the previous implementation that wrote logs to file. It was done in the shared module, and used kodein-memory to access and write logs to files. We now delegate that to the application layer, either swift-log (using FileLogger) on iOS or slf4j on Android.
iOS
There are two issues with OSLog (new Apple logging system) which prevents us from using it:
So for now, we use swift-log, configured with FileLogger. See
PassthruLogWriter.Android
Logs are sent to slf4j through the
Slf4jLogWriter. Slf4j is configured inphoenix-androidto send log to LogCat (android logs) and to write to file (with a rolling policy).