facebook share parmameter apply markdown to string #12
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkraudghgh
requested changes
Jan 26, 2017
There was a problem hiding this comment.
실제로 돌아가는 코드는 아닙니다.
Typescript 특성상 NPM module을 직접 가져다 쓸땐
Typing해야된다는 것을 저번 슬랙 채팅에서 같이 말씀하신적이 있죠. 이것이 해결되면 Merge하도록 하겠습니다.
기여 감사합니다. 꼭 필요한 기능이긴 해요 ㅠㅠ
아래는 저번에 올려주신 링크입니다.
http://blog.nemo157.com/2014/07/typescript-and-npm-modules.html
http://stackoverflow.com/questions/36309361/using-npm-modules-in-typescript
| @@ -8,6 +8,9 @@ import {User} from "../../../model/user.model"; | |||
| import {AuthService} from "../../../service/auth.service"; | |||
| import {Observable} from "rxjs"; | |||
|
|
|||
| import remark from "remark"; | |||
| import md2string from "mdast-util-to-string"; | |||
There was a problem hiding this comment.
ㅠㅠ Typing이 안되어있어서 바로 가져다 쓸 수 없는게 좀 충격이네요
|
흡.. ㅜㅜ 이제 프로젝트 빌드가 되니 시간적 여유가 될 때 타입스크립트 타이핑을 직접 시도해봐야겠군요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git에 있는 것 만으로는 ng serve가 되지 않아서 테스트는 못해봤습니다 ㅜㅜ
closes #11