Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chal 16 #27

Merged
merged 11 commits into from
Aug 18, 2024
Merged

Chal 16 #27

merged 11 commits into from
Aug 18, 2024

Conversation

noreen1423
Copy link
Contributor

Checklist

Please ensure you have followed all of the steps below before submitting a pull request:

  • Include the corresponding Jira issue key and #done in the PR title, like so: "CHAL-32 #Take the Challenge buttons on home page should send the user to /challengerwelcome"
  • Verify that the code compiles (npm run dev)
  • Verify that the project builds (npm run build)
  • Verify that all tests pass
  • Verify that unit tests cover 100% of the code
  • Create Storybook stories for visual components
  • Verify that any visual components match the Figma
  • Test with a screen reader (if applicable)
  • Document your code with TSDoc comments
  • Format your code with Prettier

Overview

REQUIRED
Fill in the overview of this PR, what this PR is trying to achieve.

Test Plan

REQUIRED
What you did to verify your PR works as claimed? Make sure to list things/steps/screenshots/screentcasts so that others can reproduce your test easily. Share styling changes and component updates through screenshots.

Follow ups

It is okay for the PR to be not perfect, list what you/other should work on after this PR is merged.

dvorakjt
dvorakjt requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@dvorakjt dvorakjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Noreen,

Looks great! Only two things:

  • Please fetch and merge the latest changes in from upstream/development and then push these changes to your fork
  • Please remove the data-testid prop from the PageContainer component as this is unused. Then regenerate the snapshots by running npm test -- -u

This is great, thank you!

src/components/utils/page-container/page-container.tsx Outdated
@@ -7,7 +7,7 @@ import styles from './styles.module.scss';
*/
export function PageContainer({ children }: PropsWithChildren) {
return (
<div className={styles.outer_container}>
<div className={styles.outer_container} data-testid="page-container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove data-testid here as it is unused.

dvorakjt
dvorakjt approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@dvorakjt dvorakjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, approved!

@dvorakjt dvorakjt merged commit 816fc1e into 8by8-org:development Aug 18, 2024
1 check passed
dvorakjt added a commit that referenced this pull request Oct 6, 2024
@dvorakjt @CaptainExtremis
@noreen1423 @IshanBhatBhardwaj
Merge latest changes from dev into staging (#46)
c7151ce 
* CHAL-47 #done - Simplify symlink creation (#25)

* finished link-or-copy-migrations-script.js

* removed copy migrations step from run-unit-tests workflow

* updated copy function

* updated supabase config files

* JRA-26 #done Implement 404 Page (#26)

* Implemented authguard class and tests

* Added unauthguard components.

* Finalized UnAuthGuard component.

* Stage commit for 404 page

* Added supabase functionality

* Created base 404 page.

* Implemented Not Found page

* Removed unneccesary page

* Fixed merge conflicts

---------

Co-authored-by: Joseph Dvorak <[email protected]>

* Chal 16 (#27)

* CHAL-16: Fixed page height

* CHAL-16: Fixed page height

* final update

* removed the page container test

* Adding take challenge button

* Take the Challenge styled correctly, and added test

* removed line 5 queryAllByRole

* Removed unused data-testid prop from PageContainer and updated snapshots

* CHAL-46 #done - Update Badge type to include election reminders action (#28)

* updated types, services, types, tests and stories to reflect additional badge type

* removed commented out tests

* Fix issue due to RLS policies and createClient (#32)

* added createServiceRoleClient function

* updated TSDoc comments

* CHAL-39 #done - Award election reminders badge (#33)

* added plpgsql functions for awarding badges

* updated migrations

* refined plpgsql functions

* removed strict keyword from award_badge plpgsql func to allow for null arguments

* restricted permissions on functions

* created plpgsql function to get user

* added get_user_by_id function

* fixed failing tests

* added supabase-user-record-builder

* added tests for SupabaseUserRepository

* added tests for SupabaseUserRecordBuilder

* finished tests for SupabaseUserRepository

* added tests for award-election-reminders-badge route

* completed tests

* formatted code

* removed test:db command

* added check to ensure that the user is still signed in when gotElectionReminders updates the user

* CHAL-37 #done Create API route for voter registration (#31)

* Deleted a provider

* added dataEncryption class and unit tests

* added comments to class code

* fixed small bugs

* fixed PR changes as requested.

* more PR changes as requested

* deleted unused file

* updated comments for decrypt method

* created a new entry for the database. Began to add symlink for the database migration and test file

* created symlink for 20240711063356_initial_schema.sql

* added comments and formated code

* Created a script to copy the migration file into the test directory

* Made pr changes, fixed symlink script bug

* Added the sql file to the test folder

* run copy-migration-to-test-folder script before supabase script

* changed paths of scripts to get the checks to pass in github

* running the copy migration file during the test:ci

* changed scripts so that it doesnt just copy the file. It now does the entire directory

* added the idNumber field to table

* PR review changes

* added state field to the database table

* changed state_ -> us_state

* api task in progress

* voter registration tests are passing

* all tests passing, moved voter repo methods to user repo, added transform step to reading cry
ptoKey

* added optinal fields to the voter registration table

* ran npm run format

* created a util function to create a user in tests

* fixed syntax errors in migration file

* added npm run create-cryptokey to workflow to prevent errors

* added cryptoKey variable to the run-unit-tests.yml file

* added more tests to reach 100% coverage

* made some changes as request, need to write better tests to get full coverage

* pr review changes

* changed action -> action_type for badge insertions

* worked on reading private env variables

* Fixed up read private environment variables bug

* CHAL-74 #done - Load invited by data from cookies (#34)

* removed invitedBy from User type

* added invitedBy to UserContext

* set invite code cookie

* added InvitationsRepository

* updated auth class

* updated api route and auth to load invitedBy

* session.invitedBy is now loaded via a cookie

* refactored auth, added guard to prevent user from inviting themselves

* fixed failing ClientSideUserContextProvider tests

* fixed failing tests

* added tests for middleware

* added tests for SupabaseUserRepository

* added tests for SupabaseInvitationsRepository

* added unit tests for SupabaseAuth

* linted and formatted

* fixed build-time error

* fixed failing tests

* fixed extra slash

* fixed failing tests

* brought test coverage back to 100%

* refactored voter registration code and tests

* fixed env variable name in run-unit-tests.yml

* CHAL-30 #DONE Voter registration form (#30)

* added register route

* added checkbox component and story

* added voter registration form and pages

* added phone input

* fixed select menu page overflow issue

* refined eligibility page

* added tests for phone input

* refined names form

* cleaned up addresses form

* added tests for ZipCodeValidator, PhoneValidator, and useRedirectToFirstIncompletePage. Cleaned up modal tests.

* fixed overflow issue on addresses page due to select component input width

* fixed typos, added error alert and loading wheel to other details page, forms focus on first nonvalid input when submitted while invalid

* added persistent fields, rendered voter registration form pages on the the client

* installed latest version of fully-formed and audited npm packages

* added address confirmation components and stories

* added hook to prefetch other details page when home state and zip change

* implemented address confirmation modal

* added address validation service

* added types for google address validation, updated components and stories, added validateAddresses client util

* fixed false positive returned by shouldCreateReviewRecommendedAddressError

* replaced google maps skd with calls to http api as the sdk uses eval internally

* added function to apply caution validity to address form fields

* added warning icons to input elements

* added hook to check if any form elements are invalid

* improved aria

* fixed broken tests, added test for validateAddressesWithGoogleMaps

* added tests for validateAddressesWithGoogleMaps

* added more tests

* added tests for addresses page

* added focus functionality back to select component, fixed missing act() warnings, added tests for usePrefetch

* added more tests for the combobox element

* tested warning icon display in select component

* test coverage outside of register route back up to 100%

* added tests for names form

* added tests for eligibility

* added test for VoterRegistrationForm

* completed tests for src/app/register/eligibility

* added tests for other details page

* added tests for addresses utils

* addeed tests for usePrefetchOtherDetailsWithStateAndZip

* added tests for address forms

* added tests for address forms

* added tests for FormattedAddress

* added final tests, formatted, linted

* small UI updates

* exported PhoneInputGroup from index.tsx

* removed superfluous files

* removed superfluous files

* fixed type errors, linted, and formatted

* CHAL-63 #done - Load state requirements (#35)

* added StateInformationModal

* fixed failing tests

* added tests for StateInformationModal and fixed tests for voter registration route

* loaded political party and race options from rock the vote

* retrieved political parties and other details from rock the vote

* fixed failing tests, added tests for rtv-us-state-information

* CHAL-53 #done - Implement election reminders page (#36)

* added election reminders page

* added tests

* added tests

* added pledge-to-vote-iframe to coveragePathIgnorePatterns array

* CHAL-54 #done, CHAL-57 #done - Add guards, refactor middleware, add favicon (#38)

* added guards, added comments to existing guards

* added tests for new guards

* guards now return null if the user will be redirected to allow chaining

* added guards to all protected routes

* added new middleware functions

* removed redirect-to-eligibility-middleware

* fixed middleware bugs, added favicon, added signin link to signin-with-otp page

* fixed failing tests

* added tests for middleware

* added TSDoc comment and formatted

* CHAL-44 #done - Enable realtime updates on badges table (#39)

* added make_hybrid plpgsql function

* added explicit order by when retrieving badges

* added explicit order by to contributed_to upon retrieval

* added challengerInviteCode to contributedTo

* enabled realtime on badges

* added tests for realtime updates

* tested the order of the items in the user.contributedTo array

* CHAL 77: #done Add PlayerWelcome page CHAL 49: #done Style One Time Passcode email template (#42)

* Implemented authguard class and tests

* Added unauthguard components.

* Finalized UnAuthGuard component.

* Stage commit for 404 page

* Added supabase functionality

* Created base 404 page.

* Implemented Not Found page

* Removed unneccesary page

* Fixed merge conflicts

* Forked new branch for Chal-77

* Added Token to OTP.html

* Added inline CSS to one-time-passcode.html

* Added functionality for the PlayerWelcome page

* Fixed missing Page Container import

* Fixed build errors

---------

Co-authored-by: Joseph Dvorak <[email protected]>

* CHAL-62 #done, CHAL-76 #done - Add actions page (#41)

* added make_hybrid plpgsql function

* added explicit order by when retrieving badges

* added explicit order by to contributed_to upon retrieval

* added challengerInviteCode to contributedTo

* enabled realtime on badges

* added tests for realtime updates

* tested the order of the items in the user.contributedTo array

* began implementing actions page

* added take-the-challenge route and available actions UI component

* added links component

* added unit tests

* added unit tests for AvailableActions

* added tests for Hero component

* added tests for actions page and links component

* add tests for lastContributedToCurrentInviter, format and fix linting errors

* extracted TakeTheChallengeModal into a standalone component

* call takeTheChallenge when player clicks takeTheChallenge, make layout fullscreen in header stories

* player links displays a loading wheel while takeTheChallenge is in progress

* fixed empty index.tsx file

* fixed empty index.tsx file

* CHAL-78 #done - Add guards to PlayerWelcome page (#44)

* added guards to PlayerWelcome page, removed fallback text as invitedBy cannot be null when the page is wrapped in the wasInvited guard

* replace Button with LinkButton in /playerwelcome

* fixed typo on player welcome page

* CHAL-58 #done, CHAL-71 #done, CHAL-72 #done, CHAL-73 #done - Add TOS and Privacy Policy pages, remove dead links and references to getting rewards (#43)

* added terms of service and privacy policy pages

* removed dead links and references to rewards

* added open graph api data to metadata in root layout

* minor style correction to TOS and Privacy Policy pages, fixed broken signin and signup stories

* JIRA-36 #done Added encryptor as a dependency to cookie class (#40)

* Deleted a provider

* added dataEncryption class and unit tests

* added comments to class code

* fixed small bugs

* fixed PR changes as requested.

* more PR changes as requested

* deleted unused file

* updated comments for decrypt method

* created a new entry for the database. Began to add symlink for the database migration and test file

* created symlink for 20240711063356_initial_schema.sql

* added comments and formated code

* Created a script to copy the migration file into the test directory

* Made pr changes, fixed symlink script bug

* Added the sql file to the test folder

* run copy-migration-to-test-folder script before supabase script

* changed paths of scripts to get the checks to pass in github

* running the copy migration file during the test:ci

* changed scripts so that it doesnt just copy the file. It now does the entire directory

* added the idNumber field to table

* PR review changes

* added state field to the database table

* changed state_ -> us_state

* api task in progress

* voter registration tests are passing

* all tests passing, moved voter repo methods to user repo, added transform step to reading cry
ptoKey

* added optinal fields to the voter registration table

* ran npm run format

* created a util function to create a user in tests

* fixed syntax errors in migration file

* added npm run create-cryptokey to workflow to prevent errors

* added cryptoKey variable to the run-unit-tests.yml file

* added more tests to reach 100% coverage

* made some changes as request, need to write better tests to get full coverage

* pr review changes

* changed action -> action_type for badge insertions

* worked on reading private env variables

* Fixed up read private environment variables bug

* Added encryptor as a dependency for cookies, created new .env variable for cookies

* ran npm run format and recovered a test that I deleted by mistake in cookies.test.ts

* deleted copy of my voterRegistrationRepo

* deleted old create user util

* deleted create-user.test.ts file

* Fixed some typos and unused imports

* fixed syntax error

---------

Co-authored-by: Joseph Dvorak <[email protected]>

* CHAL-60 #done, CHAL-61 #done - Connect voter registration form and api (#45)

* updated backend to interface with rock the vote

* refactored register to vote route to use RTV api

* /api/register-to-vote now returns an object with a user property as the response body

* implemented register/completed page

* added guards to voter registration pages

* added scrollToTop to OtherDetails

* fixed autocomplete bug in PhoneInput

* fixed failing tests for /register-to-vote route

* fixed failing voter-registration-data-repository tests

* fixed failing other-details/get-first-non-valid-input-id tests

* fixed failing tests

* add tests for register/eligibility and register/other-details

* added tests and stories

* added tests for /register/completed page

---------

Co-authored-by: Phillip D <[email protected]>
Co-authored-by: noreen1423 <[email protected]>
Co-authored-by: IshanBhatBhardwaj <[email protected]>
dvorakjt added a commit that referenced this pull request Oct 7, 2024
@dvorakjt @CaptainExtremis
@noreen1423 @IshanBhatBhardwaj
Fix broken pipe error in deploy script (#48)
983f442 
* CHAL-47 #done - Simplify symlink creation (#25)

* finished link-or-copy-migrations-script.js

* removed copy migrations step from run-unit-tests workflow

* updated copy function

* updated supabase config files

* JRA-26 #done Implement 404 Page (#26)

* Implemented authguard class and tests

* Added unauthguard components.

* Finalized UnAuthGuard component.

* Stage commit for 404 page

* Added supabase functionality

* Created base 404 page.

* Implemented Not Found page

* Removed unneccesary page

* Fixed merge conflicts

---------

Co-authored-by: Joseph Dvorak <[email protected]>

* Chal 16 (#27)

* CHAL-16: Fixed page height

* CHAL-16: Fixed page height

* final update

* removed the page container test

* Adding take challenge button

* Take the Challenge styled correctly, and added test

* removed line 5 queryAllByRole

* Removed unused data-testid prop from PageContainer and updated snapshots

* CHAL-46 #done - Update Badge type to include election reminders action (#28)

* updated types, services, types, tests and stories to reflect additional badge type

* removed commented out tests

* Fix issue due to RLS policies and createClient (#32)

* added createServiceRoleClient function

* updated TSDoc comments

* CHAL-39 #done - Award election reminders badge (#33)

* added plpgsql functions for awarding badges

* updated migrations

* refined plpgsql functions

* removed strict keyword from award_badge plpgsql func to allow for null arguments

* restricted permissions on functions

* created plpgsql function to get user

* added get_user_by_id function

* fixed failing tests

* added supabase-user-record-builder

* added tests for SupabaseUserRepository

* added tests for SupabaseUserRecordBuilder

* finished tests for SupabaseUserRepository

* added tests for award-election-reminders-badge route

* completed tests

* formatted code

* removed test:db command

* added check to ensure that the user is still signed in when gotElectionReminders updates the user

* CHAL-37 #done Create API route for voter registration (#31)

* Deleted a provider

* added dataEncryption class and unit tests

* added comments to class code

* fixed small bugs

* fixed PR changes as requested.

* more PR changes as requested

* deleted unused file

* updated comments for decrypt method

* created a new entry for the database. Began to add symlink for the database migration and test file

* created symlink for 20240711063356_initial_schema.sql

* added comments and formated code

* Created a script to copy the migration file into the test directory

* Made pr changes, fixed symlink script bug

* Added the sql file to the test folder

* run copy-migration-to-test-folder script before supabase script

* changed paths of scripts to get the checks to pass in github

* running the copy migration file during the test:ci

* changed scripts so that it doesnt just copy the file. It now does the entire directory

* added the idNumber field to table

* PR review changes

* added state field to the database table

* changed state_ -> us_state

* api task in progress

* voter registration tests are passing

* all tests passing, moved voter repo methods to user repo, added transform step to reading cry
ptoKey

* added optinal fields to the voter registration table

* ran npm run format

* created a util function to create a user in tests

* fixed syntax errors in migration file

* added npm run create-cryptokey to workflow to prevent errors

* added cryptoKey variable to the run-unit-tests.yml file

* added more tests to reach 100% coverage

* made some changes as request, need to write better tests to get full coverage

* pr review changes

* changed action -> action_type for badge insertions

* worked on reading private env variables

* Fixed up read private environment variables bug

* CHAL-74 #done - Load invited by data from cookies (#34)

* removed invitedBy from User type

* added invitedBy to UserContext

* set invite code cookie

* added InvitationsRepository

* updated auth class

* updated api route and auth to load invitedBy

* session.invitedBy is now loaded via a cookie

* refactored auth, added guard to prevent user from inviting themselves

* fixed failing ClientSideUserContextProvider tests

* fixed failing tests

* added tests for middleware

* added tests for SupabaseUserRepository

* added tests for SupabaseInvitationsRepository

* added unit tests for SupabaseAuth

* linted and formatted

* fixed build-time error

* fixed failing tests

* fixed extra slash

* fixed failing tests

* brought test coverage back to 100%

* refactored voter registration code and tests

* fixed env variable name in run-unit-tests.yml

* CHAL-30 #DONE Voter registration form (#30)

* added register route

* added checkbox component and story

* added voter registration form and pages

* added phone input

* fixed select menu page overflow issue

* refined eligibility page

* added tests for phone input

* refined names form

* cleaned up addresses form

* added tests for ZipCodeValidator, PhoneValidator, and useRedirectToFirstIncompletePage. Cleaned up modal tests.

* fixed overflow issue on addresses page due to select component input width

* fixed typos, added error alert and loading wheel to other details page, forms focus on first nonvalid input when submitted while invalid

* added persistent fields, rendered voter registration form pages on the the client

* installed latest version of fully-formed and audited npm packages

* added address confirmation components and stories

* added hook to prefetch other details page when home state and zip change

* implemented address confirmation modal

* added address validation service

* added types for google address validation, updated components and stories, added validateAddresses client util

* fixed false positive returned by shouldCreateReviewRecommendedAddressError

* replaced google maps skd with calls to http api as the sdk uses eval internally

* added function to apply caution validity to address form fields

* added warning icons to input elements

* added hook to check if any form elements are invalid

* improved aria

* fixed broken tests, added test for validateAddressesWithGoogleMaps

* added tests for validateAddressesWithGoogleMaps

* added more tests

* added tests for addresses page

* added focus functionality back to select component, fixed missing act() warnings, added tests for usePrefetch

* added more tests for the combobox element

* tested warning icon display in select component

* test coverage outside of register route back up to 100%

* added tests for names form

* added tests for eligibility

* added test for VoterRegistrationForm

* completed tests for src/app/register/eligibility

* added tests for other details page

* added tests for addresses utils

* addeed tests for usePrefetchOtherDetailsWithStateAndZip

* added tests for address forms

* added tests for address forms

* added tests for FormattedAddress

* added final tests, formatted, linted

* small UI updates

* exported PhoneInputGroup from index.tsx

* removed superfluous files

* removed superfluous files

* fixed type errors, linted, and formatted

* CHAL-63 #done - Load state requirements (#35)

* added StateInformationModal

* fixed failing tests

* added tests for StateInformationModal and fixed tests for voter registration route

* loaded political party and race options from rock the vote

* retrieved political parties and other details from rock the vote

* fixed failing tests, added tests for rtv-us-state-information

* CHAL-53 #done - Implement election reminders page (#36)

* added election reminders page

* added tests

* added tests

* added pledge-to-vote-iframe to coveragePathIgnorePatterns array

* CHAL-54 #done, CHAL-57 #done - Add guards, refactor middleware, add favicon (#38)

* added guards, added comments to existing guards

* added tests for new guards

* guards now return null if the user will be redirected to allow chaining

* added guards to all protected routes

* added new middleware functions

* removed redirect-to-eligibility-middleware

* fixed middleware bugs, added favicon, added signin link to signin-with-otp page

* fixed failing tests

* added tests for middleware

* added TSDoc comment and formatted

* CHAL-44 #done - Enable realtime updates on badges table (#39)

* added make_hybrid plpgsql function

* added explicit order by when retrieving badges

* added explicit order by to contributed_to upon retrieval

* added challengerInviteCode to contributedTo

* enabled realtime on badges

* added tests for realtime updates

* tested the order of the items in the user.contributedTo array

* CHAL 77: #done Add PlayerWelcome page CHAL 49: #done Style One Time Passcode email template (#42)

* Implemented authguard class and tests

* Added unauthguard components.

* Finalized UnAuthGuard component.

* Stage commit for 404 page

* Added supabase functionality

* Created base 404 page.

* Implemented Not Found page

* Removed unneccesary page

* Fixed merge conflicts

* Forked new branch for Chal-77

* Added Token to OTP.html

* Added inline CSS to one-time-passcode.html

* Added functionality for the PlayerWelcome page

* Fixed missing Page Container import

* Fixed build errors

---------

Co-authored-by: Joseph Dvorak <[email protected]>

* CHAL-62 #done, CHAL-76 #done - Add actions page (#41)

* added make_hybrid plpgsql function

* added explicit order by when retrieving badges

* added explicit order by to contributed_to upon retrieval

* added challengerInviteCode to contributedTo

* enabled realtime on badges

* added tests for realtime updates

* tested the order of the items in the user.contributedTo array

* began implementing actions page

* added take-the-challenge route and available actions UI component

* added links component

* added unit tests

* added unit tests for AvailableActions

* added tests for Hero component

* added tests for actions page and links component

* add tests for lastContributedToCurrentInviter, format and fix linting errors

* extracted TakeTheChallengeModal into a standalone component

* call takeTheChallenge when player clicks takeTheChallenge, make layout fullscreen in header stories

* player links displays a loading wheel while takeTheChallenge is in progress

* fixed empty index.tsx file

* fixed empty index.tsx file

* CHAL-78 #done - Add guards to PlayerWelcome page (#44)

* added guards to PlayerWelcome page, removed fallback text as invitedBy cannot be null when the page is wrapped in the wasInvited guard

* replace Button with LinkButton in /playerwelcome

* fixed typo on player welcome page

* CHAL-58 #done, CHAL-71 #done, CHAL-72 #done, CHAL-73 #done - Add TOS and Privacy Policy pages, remove dead links and references to getting rewards (#43)

* added terms of service and privacy policy pages

* removed dead links and references to rewards

* added open graph api data to metadata in root layout

* minor style correction to TOS and Privacy Policy pages, fixed broken signin and signup stories

* JIRA-36 #done Added encryptor as a dependency to cookie class (#40)

* Deleted a provider

* added dataEncryption class and unit tests

* added comments to class code

* fixed small bugs

* fixed PR changes as requested.

* more PR changes as requested

* deleted unused file

* updated comments for decrypt method

* created a new entry for the database. Began to add symlink for the database migration and test file

* created symlink for 20240711063356_initial_schema.sql

* added comments and formated code

* Created a script to copy the migration file into the test directory

* Made pr changes, fixed symlink script bug

* Added the sql file to the test folder

* run copy-migration-to-test-folder script before supabase script

* changed paths of scripts to get the checks to pass in github

* running the copy migration file during the test:ci

* changed scripts so that it doesnt just copy the file. It now does the entire directory

* added the idNumber field to table

* PR review changes

* added state field to the database table

* changed state_ -> us_state

* api task in progress

* voter registration tests are passing

* all tests passing, moved voter repo methods to user repo, added transform step to reading cry
ptoKey

* added optinal fields to the voter registration table

* ran npm run format

* created a util function to create a user in tests

* fixed syntax errors in migration file

* added npm run create-cryptokey to workflow to prevent errors

* added cryptoKey variable to the run-unit-tests.yml file

* added more tests to reach 100% coverage

* made some changes as request, need to write better tests to get full coverage

* pr review changes

* changed action -> action_type for badge insertions

* worked on reading private env variables

* Fixed up read private environment variables bug

* Added encryptor as a dependency for cookies, created new .env variable for cookies

* ran npm run format and recovered a test that I deleted by mistake in cookies.test.ts

* deleted copy of my voterRegistrationRepo

* deleted old create user util

* deleted create-user.test.ts file

* Fixed some typos and unused imports

* fixed syntax error

---------

Co-authored-by: Joseph Dvorak <[email protected]>

* CHAL-60 #done, CHAL-61 #done - Connect voter registration form and api (#45)

* updated backend to interface with rock the vote

* refactored register to vote route to use RTV api

* /api/register-to-vote now returns an object with a user property as the response body

* implemented register/completed page

* added guards to voter registration pages

* added scrollToTop to OtherDetails

* fixed autocomplete bug in PhoneInput

* fixed failing tests for /register-to-vote route

* fixed failing voter-registration-data-repository tests

* fixed failing other-details/get-first-non-valid-input-id tests

* fixed failing tests

* add tests for register/eligibility and register/other-details

* added tests and stories

* added tests for /register/completed page

* Update deploy-and-test-staging-branch.yml

Patch the deploy-and-test-staging-branch.yml workflow as the command `yes | supabase db reset --linked` recently started failing.

Please see this issue for more information:
supabase/cli#2341

---------

Co-authored-by: Phillip D <[email protected]>
Co-authored-by: noreen1423 <[email protected]>
Co-authored-by: IshanBhatBhardwaj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvorakjt dvorakjt dvorakjt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noreen1423 @dvorakjt