Bump GitHub actions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walro
force-pushed
the
bump-actions
branch
2 times, most recently
from
c641531 to
83d8f25
Compare
Both emit deprecation warnings and `upload-artifact` will start with brownouts on Nov 14. There are breaking changes https://github.com/actions/upload-artifact/blob/v4.4.3/docs/MIGRATION.md why we need to give unique names for each artifact.
Didn't spot anything breaking when glancing at changelogs.
> FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
|
I think this is fine, otherwise we'll just have some fun next time we make a release :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY / WHAT are these changes introduced?
upload-artifact@v3is deprecated and will start with brownouts on Nov 14. We had tons of warnings from other actions, so decided to bump them all.For
upload-artifact, there are breaking changes https://github.com/actions/upload-artifact/blob/v4.4.3/docs/MIGRATION.md, so we had to use unique names.Couldn't spot anything breaking for other bumps (doesn't mean there aren't any though)
HOW can this pull request be tested?
If CI runs well it covers most cases (from first glance, all of them).