Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dpkg-shlibdeps to generate dependency list for Debian package #12

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

walro
Copy link
Contributor

@walro walro commented Sep 17, 2024

WHY are these changes introduced?

The old way of doing it would mistakingly add libc6-dev as a dependency to sparoid under Ubuntu Noble (24.04) and Debian Bookworm (12).

This is the 'same' change as in cloudamqp/websocket-tcp-relay#21

WHAT is this pull request doing?

Using dpkg-shlibdeps to generate dependency list for the Debian package.

HOW can this pull request be tested?

Built Ubuntu 18.04/24.04 and Debian 10/12 locally and inspected the generated Depends: line (added after build/deb step: RUN dpkg -I $(find . -name *.deb)).

Also manually installed the 24.04 package on a 24.04 machine, and 22.04 respectively seems to work fine.

The old way of doing it would mistakingly add `libc6-dev` as a dependency to sparoid under Ubuntu Noble (24.04) and Debian Bookworm (12).

This is the 'same' change as in cloudamqp/websocket-tcp-relay#21
@walro walro marked this pull request as ready for review September 17, 2024 12:44
@walro walro requested a review from a team as a code owner September 17, 2024 12:44
@walro walro merged commit 4ca2d94 into main Sep 23, 2024
23 checks passed
@walro walro deleted the use-dpkg-shlibsdeps branch September 23, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants