Lookup public IP using HTTP #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskgu360
reviewed
Jul 23, 2024
Both OpenDNS and Google DNS has problems looking up the public IP on IPv6 connections. Lookup up using HTTP (TCP) seems more stable. The lookup time is about 110ms longer with this mechanism. checkip.amazonaws.com for now only resolvs to IPv4 addresses. If that would change we would need to lookup the A address of the domain and connect to that IP manually. It's like 2 more lines of code only, if connect_timeout isn't needed, then it's a bit more involved.
run CI for main and PR, not both, and cache bundle install, add some newer ruby versions
carlhoerberg
force-pushed
the
lookup_ip_by_http
branch
from
40f2bc9 to
7584ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Both OpenDNS and Google DNS has problems looking up the public IP on IPv6 connections. Lookup up using HTTP (TCP) seems more stable. The lookup time is about 110ms longer with this mechanism.
checkip.amazonaws.com for now only resolvs to IPv4 addresses. If that would change we would need to lookup the A address of the domain and connect to that IP manually. It's like 2 more lines of code only, if connect_timeout isn't needed, then it's a bit more involved.
WHAT is this pull request doing?
Looking up the public IP using HTTP.
HOW can this pull request be tested?
Specs