Implement SensorML2.0 Event Xml-Decoder & Json-Encoder #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * optional: swe:label [0..1] | ||
| */ | ||
| private String label; | ||
| public class SweDataStream extends AbstractSWEIdentifiable |
There was a problem hiding this comment.
You can use SweAbstractDataComponent instead of creating a new AbstractSWEIdentifiable
There was a problem hiding this comment.
If i take a look at https://portal.ogc.org/files/?artifact_id=41157 Section 7.2.2. it's the other way around - SweAbstractDataComponent should not define those field itself but extends AbstractSWEIdentifiable. Or do i miss something here?
There was a problem hiding this comment.
From the spec perspective you are correct but we have merged some classes from the spec into one class in our implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits