-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support tablet auth and flag to disable auth #3885
Conversation
…nd all internal services
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
=============================================
- Coverage 75.13% 41.22% -33.92%
Complexity 658 658
=============================================
Files 753 197 -556
Lines 135134 11805 -123329
Branches 1978 1979 +1
=============================================
- Hits 101538 4867 -96671
+ Misses 33292 6634 -26658
Partials 304 304 ☔ View full report in Codecov by Sentry. |
Linux Test Report 59 files 252 suites 1h 43m 16s ⏱️ Results for commit dece628. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add doc:
- how to use flag in server side, which servers, need restart
- how to use in client side, which clients, need restart
Release test should follow the steps in doc.
是不是所有server和client(java python cli)都能用这个开关 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
skip_grant_tables
flag to disable authWhat is the current behavior? (You can also link to an open issue here)
Tablet servers have only service-auth enabled, trusting the sdefault token.
What is the new behavior (if this is a feature change)?
Tablet servers will use the username and password from the user table for authentication