-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ip validation in diag rpc helper #3580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
============================================
- Coverage 75.32% 75.30% -0.02%
Complexity 587 587
============================================
Files 719 719
Lines 129830 129830
Branches 1280 1280
============================================
- Hits 97790 97768 -22
- Misses 31754 31776 +22
Partials 286 286 ☔ View full report in Codecov by Sentry. |
SDK Test Report100 files ±0 100 suites ±0 2m 17s ⏱️ -33s Results for commit 1a4965c. ± Comparison against base commit d00449d. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
|
localhost:xxxx is legal ip too