-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: left join #3576
Merged
Merged
feat: left join #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
execute-engine
hybridse sql engine
storage-engine
openmldb storage engine. nameserver & tablet
labels
Oct 30, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3576 +/- ##
=============================================
+ Coverage 40.14% 75.39% +35.25%
Complexity 635 635
=============================================
Files 191 727 +536
Lines 11207 130597 +119390
Branches 1317 1317
=============================================
+ Hits 4499 98468 +93969
- Misses 6417 31838 +25421
Partials 291 291 ☔ View full report in Codecov by Sentry. |
aceforeverd
force-pushed
the
feat-left-join
branch
2 times, most recently
from
November 1, 2023 15:47
1437ce9
to
f63f85d
Compare
aceforeverd
force-pushed
the
feat-left-join
branch
2 times, most recently
from
November 2, 2023 14:11
5e255d1
to
f315fd2
Compare
aceforeverd
requested review from
tobegit3hub,
dl239,
vagetablechicken and
lqy222
November 3, 2023 05:19
aceforeverd
force-pushed
the
feat-left-join
branch
from
November 9, 2023 16:25
e5e4d64
to
927744e
Compare
lqy222
approved these changes
Nov 14, 2023
dl239
approved these changes
Nov 15, 2023
runner.cc is too large, sepreate RunnerBuilder, RunnerContext, Runner and ClusterTask in difference files
For REQUESTJOIN(ANY1(T1), ANY2(T2)), ANY1 may optimize T1, REQUESTJOIN, ANY2 may optimize T2, building cluster task correctly
aceforeverd
force-pushed
the
feat-left-join
branch
from
November 15, 2023 03:32
927744e
to
eab8951
Compare
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of a LEFT OUTER JOIN (or simply LEFT JOIN) for two from_items always retains all rows of the left from_item in the JOIN operation, even if no rows in the right from_item satisfy the join predicate.
Syntax
Example:
Online Requirements
A simple LEFT JOIN can not online directly, since it always outputs a table. But LEFT JOIN can ack as a subquery inside other queries, currently we only consider LAST JOIN (maybe work on WINDOW or WINDOW UNION later)
LEFT JOIN can be the right source of a LAST JOIN query, format of