-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: last join on window #3565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aceforeverd
force-pushed
the
feat-last-join-window
branch
from
October 24, 2023 10:07
28229cc
to
c64ca4b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3565 +/- ##
============================================
- Coverage 75.31% 75.27% -0.05%
Complexity 587 587
============================================
Files 719 719
Lines 129836 130167 +331
Branches 1280 1280
============================================
+ Hits 97787 97983 +196
- Misses 31763 31898 +135
Partials 286 286
☔ View full report in Codecov by Sentry. |
aceforeverd
force-pushed
the
feat-last-join-window
branch
from
October 24, 2023 13:27
c64ca4b
to
028f961
Compare
aceforeverd
force-pushed
the
feat-last-join-window
branch
from
October 25, 2023 16:18
028f961
to
26f5af2
Compare
aceforeverd
commented
Oct 26, 2023
aceforeverd
force-pushed
the
feat-last-join-window
branch
from
October 26, 2023 08:59
26f5af2
to
b39cb17
Compare
github-actions
bot
added
the
storage-engine
openmldb storage engine. nameserver & tablet
label
Oct 26, 2023
aceforeverd
requested review from
tobegit3hub,
dl239,
vagetablechicken and
lqy222
November 3, 2023 05:19
aceforeverd
force-pushed
the
feat-last-join-window
branch
from
November 9, 2023 14:08
b39cb17
to
e4ad2e5
Compare
lqy222
approved these changes
Nov 14, 2023
dl239
approved these changes
Nov 15, 2023
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting online for this kind of SQLs:
RESTRICTIONS
tx.ID
, where ID must resolve to the column from actual table, which ist2
in the SQL above, not from the window agg resulttx.ID
, another index key referred by WINDOW PARTITION BY column