Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize insert in java sdk #3525

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Sep 22, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 151 lines in your changes are missing coverage. Please review.

Comparison is base (9401a5e) 75.35% compared to head (8f6213b) 75.39%.

Files Patch % Lines
...openmldb/sdk/impl/InsertPreparedStatementImpl.java 62.91% 49 Missing and 7 partials ⚠️
src/sdk/sql_cluster_router.cc 0.00% 45 Missing ⚠️
...openmldb/sdk/impl/InsertPreparedStatementMeta.java 78.64% 16 Missing and 6 partials ⚠️
...om/_4paradigm/openmldb/jdbc/SQLInsertMetaData.java 60.00% 4 Missing and 2 partials ⚠️
.../main/java/com/_4paradigm/openmldb/sdk/Common.java 0.00% 6 Missing ⚠️
...penmldb/sdk/impl/InsertPreparedStatementCache.java 84.61% 4 Missing and 2 partials ⚠️
...paradigm/openmldb/sdk/impl/SqlClusterExecutor.java 66.66% 5 Missing and 1 partial ⚠️
...digm/openmldb/common/codec/FlexibleRowBuilder.java 0.00% 1 Missing and 1 partial ⚠️
.../java/com/_4paradigm/openmldb/sdk/QueryFuture.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3525      +/-   ##
============================================
+ Coverage     75.35%   75.39%   +0.03%     
- Complexity      587      634      +47     
============================================
  Files           717      719       +2     
  Lines        129893   130000     +107     
  Branches       1280     1315      +35     
============================================
+ Hits          97886    98011     +125     
+ Misses        31737    31714      -23     
- Partials        270      275       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 marked this pull request as ready for review September 26, 2023 12:20
@dl239 dl239 merged commit 125483b into 4paradigm:main Nov 15, 2023
20 of 22 checks passed
@dl239 dl239 deleted the feat/java_sdk_insert branch November 15, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants