Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get trans-failed column and relax json #3521

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Sep 19, 2023

closes #3504
http response show which column trans failed
relax check, it's ok to input integer for double columns

closes #3550
support read nan/inf, write nan/inf or null for them

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (d00449d) 75.32% compared to head (471c4e5) 75.31%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/apiserver/api_server_test.cc 0.00% 88 Missing ⚠️
src/apiserver/api_server_impl.cc 0.00% 44 Missing ⚠️
src/apiserver/json_helper.cc 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3521      +/-   ##
============================================
- Coverage     75.32%   75.31%   -0.01%     
  Complexity      587      587              
============================================
  Files           719      717       -2     
  Lines        129830   129969     +139     
  Branches       1280     1280              
============================================
+ Hits          97790    97888      +98     
- Misses        31754    31811      +57     
+ Partials        286      270      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken vagetablechicken changed the title fix: get trans-failed column in api deploy req fix: get trans-failed column and relax json check Oct 11, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation build openmldb compiling and installing labels Nov 6, 2023
@vagetablechicken vagetablechicken changed the title fix: get trans-failed column and relax json check fix: get trans-failed column and relax json Nov 6, 2023
@github-actions github-actions bot added the workflow CICD related label Nov 14, 2023
@vagetablechicken vagetablechicken merged commit 825d155 into 4paradigm:main Nov 15, 2023
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server build openmldb compiling and installing documentation Improvements or additions to documentation workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api server: json double nan/inf apiserver log which column failed
3 participants