Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Logger, replace existing logging #193

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

marcus-talbot42
Copy link
Contributor

  • Replaced Logger in individual classes, with centralised instance in BeanMapperLogger.

- Replaced Logger in individual classes, with centralised instance in BeanMapperLogger.
- Separated BeanMapperLogger into BeanMapperPerformanceLogger and BeanMapperTraceLogger.
- Updated names of methods in Loggers, to better reflect their purpose.
- Removed logging from Exception constructors.
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 86.81319% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 87.73%. Comparing base (16fe0bd) to head (93310ab).

Files Patch % Lines
.../beanmapper/utils/BeanMapperPerformanceLogger.java 66.66% 5 Missing ⚠️
src/main/java/io/beanmapper/core/BeanMatch.java 50.00% 0 Missing and 1 partial ⚠️
...ain/java/io/beanmapper/core/BeanPropertyMatch.java 66.66% 1 Missing ⚠️
...apper/core/constructor/DefaultBeanInitializer.java 66.66% 1 Missing ⚠️
...core/converter/impl/ObjectToOptionalConverter.java 50.00% 1 Missing ⚠️
...o/beanmapper/core/unproxy/SkippingBeanUnproxy.java 0.00% 0 Missing and 1 partial ⚠️
...ava/io/beanmapper/utils/BeanMapperTraceLogger.java 83.33% 1 Missing ⚠️
src/main/java/io/beanmapper/utils/Classes.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #193      +/-   ##
============================================
- Coverage     88.17%   87.73%   -0.45%     
- Complexity      976      992      +16     
============================================
  Files           106      108       +2     
  Lines          2165     2193      +28     
  Branches        248      249       +1     
============================================
+ Hits           1909     1924      +15     
- Misses          161      175      +14     
+ Partials         95       94       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Separated BeanMapperLogger into BeanMapperPerformanceLogger and BeanMapperTraceLogger.
- Updated names of methods in Loggers, to better reflect their purpose.
- Removed logging from Exception constructors.
- Fixed NPE where canonical name can be null, due to constraints set by Class#getCanonicalName(void).
@marcus-talbot42 marcus-talbot42 merged commit 806b09d into master Feb 27, 2024
2 of 4 checks passed
@marcus-talbot42 marcus-talbot42 deleted the dev/logging branch February 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants