-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Logger, replace existing logging #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcus-talbot42
commented
Feb 15, 2024
- Replaced Logger in individual classes, with centralised instance in BeanMapperLogger.
- Replaced Logger in individual classes, with centralised instance in BeanMapperLogger.
- Separated BeanMapperLogger into BeanMapperPerformanceLogger and BeanMapperTraceLogger. - Updated names of methods in Loggers, to better reflect their purpose. - Removed logging from Exception constructors.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
============================================
- Coverage 88.17% 87.73% -0.45%
- Complexity 976 992 +16
============================================
Files 106 108 +2
Lines 2165 2193 +28
Branches 248 249 +1
============================================
+ Hits 1909 1924 +15
- Misses 161 175 +14
+ Partials 95 94 -1 ☔ View full report in Codecov by Sentry. |
sptdevos
reviewed
Feb 15, 2024
sptdevos
reviewed
Feb 19, 2024
- Separated BeanMapperLogger into BeanMapperPerformanceLogger and BeanMapperTraceLogger. - Updated names of methods in Loggers, to better reflect their purpose. - Removed logging from Exception constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.