[TDC-47] 비로그인 상태에서 성능 개선

3dollar-in-my-pocket · Jan 29, 2024 · e8b4828 · e8b4828
1 parent 024cc70
commit e8b4828
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/...ollar-application/src/main/java/com/threedollar/controller/sticker/StickerController.java b/...ollar-application/src/main/java/com/threedollar/controller/sticker/StickerController.java
@@ -37,7 +37,7 @@ public ApiResponse<String> createReaction(@Valid @RequestBody AddReactionRequest
     public ApiResponse<List<TargetStickerAction>> getTargetStickerReactions(@PathVariable StickerGroup stickerGroup,
                                                                             @RequestParam Set<String> targetIds,
                                                                             @RequestParam(required = false) String accountId) {
-        return ApiResponse.success(stickerFacadeService.getTargetStickerReactionResponse(stickerGroup, accountId, targetIds));
+        return ApiResponse.success(stickerFacadeService.getTargetStickers(stickerGroup, accountId, targetIds));
     }
 
 }
diff --git a/...ollar-application/src/main/java/com/threedollar/service/sticker/StickerActionService.java b/...ollar-application/src/main/java/com/threedollar/service/sticker/StickerActionService.java
@@ -11,9 +11,11 @@
 import com.threedollar.service.sticker.dto.response.TargetStickerAction;
 import com.threedollar.service.sticker.dto.request.AddReactionRequest;
 import lombok.RequiredArgsConstructor;
+import org.apache.commons.lang3.StringUtils;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -50,10 +52,10 @@ public void upsertSticker(AddReactionRequest request, StickerGroup stickerGroup,
     }
 
     @Transactional(readOnly = true)
-    public List<TargetStickerAction> getStickerReactionResponse(StickerGroup stickerGroup,
-                                                                String accountId,
-                                                                Set<String> targetIds,
-                                                                List<Sticker> stickers) {
+    public List<TargetStickerAction> getStickerActionResponse(StickerGroup stickerGroup,
+                                                              String accountId,
+                                                              Set<String> targetIds,
+                                                              List<Sticker> stickers) {
 
         Map<StickerActionCountKey, Long> stickerCountKeyLongMap = getStickerCountKey(stickerGroup, targetIds, stickers);
 
@@ -93,6 +95,9 @@ private Map<StickerActionCountKey, Long> getStickerCountKey(StickerGroup sticker
     private Map<String, StickerAction> getTargetIdActedByMe(Set<String> targetIds,
                                                             String accountId,
                                                             StickerGroup stickerGroup) {
+        if (StringUtils.isBlank(accountId)) {
+            return Collections.emptyMap();
+        }
         List<StickerAction> stickerActions = stickerActionRepository.getStickerActionByMe(accountId, targetIds, stickerGroup);
         return stickerActions.stream()
             .collect(Collectors.toMap(StickerAction::getTargetId, stickerAction -> stickerAction));

diff --git a/...ollar-application/src/main/java/com/threedollar/service/sticker/StickerFacadeService.java b/...ollar-application/src/main/java/com/threedollar/service/sticker/StickerFacadeService.java
@@ -26,9 +26,9 @@ public void upsertSticker(AddReactionRequest request, @NotNull StickerGroup stic
     }
 
 
-    public List<TargetStickerAction> getTargetStickerReactionResponse(@NotNull StickerGroup stickerGroup, String accountId, Set<String> targetIds) {
+    public List<TargetStickerAction> getTargetStickers(@NotNull StickerGroup stickerGroup, String accountId, Set<String> targetIds) {
         List<Sticker> stickers = stickerService.getStickersByStickerGroup(stickerGroup);
-        return stickerActionService.getStickerReactionResponse(stickerGroup, accountId, targetIds, stickers);
+        return stickerActionService.getStickerActionResponse(stickerGroup, accountId, targetIds, stickers);
     }