Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dedicated nodepool for OHW after event #2983

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Aug 15, 2023

@sgibson91 sgibson91 requested a review from a team as a code owner August 15, 2023 10:23
@sgibson91 sgibson91 mentioned this pull request Aug 15, 2023
9 tasks
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp 2i2c No Yes Following prod hubs require redeploy: ohw

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp 2i2c ohw Following helm chart values files were modified: ohw.values.yaml

@sgibson91
Copy link
Member Author

Output of tf plan

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # google_container_node_pool.notebook["ohw"] will be destroyed
  # (because key ["ohw"] is not in for_each map)
  - resource "google_container_node_pool" "notebook" {
      - cluster                     = "pilot-hubs-cluster" -> null
      - id                          = "projects/two-eye-two-see/locations/us-central1-b/clusters/pilot-hubs-cluster/nodePools/nb-ohw" -> null
      - initial_node_count          = 4 -> null
      - instance_group_urls         = [
          - "https://www.googleapis.com/compute/v1/projects/two-eye-two-see/zones/us-central1-b/instanceGroupManagers/gke-pilot-hubs-cluster-nb-ohw-8a6ced79-grp",
        ] -> null
      - location                    = "us-central1-b" -> null
      - managed_instance_group_urls = [
          - "https://www.googleapis.com/compute/v1/projects/two-eye-two-see/zones/us-central1-b/instanceGroups/gke-pilot-hubs-cluster-nb-ohw-8a6ced79-grp",
        ] -> null
      - name                        = "nb-ohw" -> null
      - node_count                  = 4 -> null
      - node_locations              = [
          - "us-central1-b",
        ] -> null
      - project                     = "two-eye-two-see" -> null
      - version                     = "1.26.5-gke.1400" -> null

      - autoscaling {
          - location_policy      = "BALANCED" -> null
          - max_node_count       = 100 -> null
          - min_node_count       = 4 -> null
          - total_max_node_count = 0 -> null
          - total_min_node_count = 0 -> null
        }

      - management {
          - auto_repair  = true -> null
          - auto_upgrade = false -> null
        }

      - node_config {
          - disk_size_gb      = 100 -> null
          - disk_type         = "pd-balanced" -> null
          - guest_accelerator = [] -> null
          - image_type        = "COS_CONTAINERD" -> null
          - labels            = {
              - "2i2c.org/community"           = "ohw"
              - "hub.jupyter.org/node-purpose" = "user"
              - "k8s.dask.org/node-purpose"    = "scheduler"
            } -> null
          - local_ssd_count   = 0 -> null
          - logging_variant   = "DEFAULT" -> null
          - machine_type      = "n2-highmem-16" -> null
          - metadata          = {
              - "disable-legacy-endpoints" = "true"
            } -> null
          - oauth_scopes      = [
              - "https://www.googleapis.com/auth/cloud-platform",
            ] -> null
          - preemptible       = false -> null
          - resource_labels   = {
              - "community" = "ohw"
            } -> null
          - service_account   = "[email protected]" -> null
          - spot              = false -> null
          - tags              = [] -> null
          - taint             = [
              - {
                  - effect = "NO_SCHEDULE"
                  - key    = "hub.jupyter.org_dedicated"
                  - value  = "user"
                },
              - {
                  - effect = "NO_SCHEDULE"
                  - key    = "2i2c.org/community"
                  - value  = "ohw"
                },
            ] -> null

          - shielded_instance_config {
              - enable_integrity_monitoring = true -> null
              - enable_secure_boot          = false -> null
            }

          - workload_metadata_config {
              - mode = "GKE_METADATA" -> null
            }
        }

      - upgrade_settings {
          - max_surge       = 1 -> null
          - max_unavailable = 0 -> null
          - strategy        = "SURGE" -> null
        }
    }

Plan: 0 to add, 0 to change, 1 to destroy.

@sgibson91
Copy link
Member Author

Applied successfully!

@sgibson91 sgibson91 merged commit e4d2ac2 into 2i2c-org:master Aug 15, 2023
8 checks passed
@sgibson91 sgibson91 deleted the ohw-event/nodepool branch August 15, 2023 13:03
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5867401433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants