Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CMake #3

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Introduce CMake #3

wants to merge 13 commits into from

Conversation

xorza
Copy link

@xorza xorza commented Sep 16, 2019

Its very hard now to integrate any library to your project if it doesn't have CMakeLists.

I opened this PR to start discussion of nima-cpp migration to CMake. Currently I tested it with CMake 3.14, with gcc 7.4, clang 8.0 and MSVC 19.22

There were a lot of changes introduced to code to satisfy all compilers:

  1. Cut out usage of M_PI, cause it is deprecated and doesn't even compile on MSVC without additional define. Instead I added MathUtils.hpp file to nima-math where I declared constexp nima::pi and piOver2
  2. Fixed bunch of double -> float implicit casts with explicit and signed-unsigned comparisons to satisfy MSVC with W3 and WX
  3. Normalized includes of nima-math headers: some of them used "" other <>.
  4. Fixed compilation warning as error on Apple Clang 10.0.1 when catching exception by value instead of reference catch (const OverflowException &ex)
  5. Removed makefiles
  6. Updated gitignore for project to be usable with CLion, VSCode, VS19 Community

Lets start discussion and if overall you accept my changes I will open PR with changes against nima-math. Here you can see nima-math diff: 2d-inc/Nima-Math-Cpp@master...xorza:master

@xorza xorza changed the title Introcude CMake Introduce CMake Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant