Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its very hard now to integrate any library to your project if it doesn't have CMakeLists.
I opened this PR to start discussion of nima-cpp migration to CMake. Currently I tested it with CMake 3.14, with gcc 7.4, clang 8.0 and MSVC 19.22
There were a lot of changes introduced to code to satisfy all compilers:
constexp nima::pi
andpiOver2
catch (const OverflowException &ex)
Lets start discussion and if overall you accept my changes I will open PR with changes against nima-math. Here you can see nima-math diff: 2d-inc/Nima-Math-Cpp@master...xorza:master