Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't directplay AAC if profile is main. Transcode the audio #42

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Don't directplay AAC if profile is main. Transcode the audio #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions source/utils/deviceCapabilities.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import "pkg:/source/utils/misc.bs"
import "pkg:/source/api/baserequest.bs"
import "pkg:/source/utils/misc.bs"

' Returns the Device Capabilities for Roku.
function getDeviceCapabilities() as object
Expand Down Expand Up @@ -138,7 +138,7 @@ function GetDirectPlayProfiles() as object

' remove audio codecs not supported as standalone audio files (opus)
' also add aac back to the list so it gets added to the direct play profile
audioCodecs = ["aac", "mp3", "mp2", "pcm", "lpcm", "wav", "ac3", "ac4", "aiff", "wma", "flac", "alac", "aac", "dts", "wmapro", "vorbis", "eac3", "mpg123"]
audioCodecs = ["mp3", "mp2", "pcm", "lpcm", "wav", "ac3", "ac4", "aiff", "wma", "flac", "alac", "aac", "dts", "wmapro", "vorbis", "eac3", "mpg123"]

' check audio codecs with no container
supportedAudio = []
Expand Down Expand Up @@ -184,9 +184,9 @@ function getTranscodingProfiles() as object

transcodingContainers = ["mp4", "ts"]
' use strings to preserve order
mp4AudioCodecs = "aac"
mp4AudioCodecs = "AC3"
mp4VideoCodecs = "h264"
tsAudioCodecs = "aac"
tsAudioCodecs = "AC3"
tsVideoCodecs = "h264"

' does the users setup support surround sound?
Expand Down Expand Up @@ -439,6 +439,25 @@ function getCodecProfiles() as object
for each codecType in ["VideoAudio", "Audio"]
if audioCodec = "opus" and codecType = "Audio"
' opus audio files not supported by roku
else if audioCodec = "aac"
codecProfiles.push({
"Type": codecType,
"Codec": audioCodec,
"Conditions": [
{
"Condition": "LessThanEqual",
"Property": "AudioChannels",
"Value": audioChannel,
"IsRequired": true
},
{
"Condition": "NotEquals",
"Property": "AudioProfile",
"Value": "Main",
"IsRequired": true
}
]
})
else
codecProfiles.push({
"Type": codecType,
Expand Down
Loading