Fix forced subs

[jimdogx]

Fix forced subs not showing up automatically.

Changes

Forces subtitles on if the subtitles are "Forced". Remembers global Roku subtitle settings so they can be returned when the video is done playing.

Issues

Subtitles will not be returned to their original settings if the user hits "Home" from the playing video.

[1hitsong]

Is this confirmed as an issue in viv?

I think a better spot for the change would be in defaultSubtitleTrack in components\ItemGrid\LoadVideoContentTask.bs

If subtitles aren't getting auto turned on for forced subtitles, that sounds more like a bug somewhere in the logic than a need to add additional check for isforced all the way up in the video player view.

[jimdogx]

Is this confirmed as an issue in viv?

100% reproducible. I have "only forced" and watching a show with "Forced" subtitles still requires me to manually turn on subtitles (and rewind the show to re-watch what I couldn't understand) 😄

I think a better spot for the change would be in defaultSubtitleTrack in components\ItemGrid\LoadVideoContentTask.bs

If subtitles aren't getting auto turned on for forced subtitles, that sounds more like a bug somewhere in the logic than a need to add additional check for isforced all the way up in the video player view.

DefaultSubtitleTrack is doing its job already:

           else if subtitleMode = "onlyforced" and item.IsForced
                ' Return first forced subtitle track
                return item.Index

The correct subtitle track is returned. The problem is, you have to actually turn "on" subtitles on the Roku for anything to show up:

"Therefore setting the global setting every time you adjust a local setting is required."

Source: https://developer.roku.com/docs/developer-program/media-playback/closed-caption.md

Viv already does this for "not encoded" subtitles, but it wasn't doing it for "forced" subtitles. So I only modified the section that was already doing this 😄

[1hitsong]

Subtitles will not be returned to their original settings if the user hits "Home" from the playing video.

That's fine.

[1hitsong]

Works perfectly!