Fix login crash

Fixes #81
1hitsong · Nov 6, 2024 · 3381699 · 3381699
1 parent 8816cee
commit 3381699
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/components/config/SigninScene.xml b/components/config/SigninScene.xml
@@ -48,7 +48,7 @@
   </children>
   <interface>
     <field id="user" type="string" onchange="onUserChange" value="" />
-    <field id="profileImageUri" type="string" onchange="onProfileImageUriChange" value="" />
+    <field id="profileImageUri" type="string" onchange="onProfileImageUriChange" value="" alwaysNotify="true" />
     <field id="alert" type="string" onchange="onAlertChange" value="" />
   </interface>
 </component>
diff --git a/source/api/Image.bs b/source/api/Image.bs
@@ -56,6 +56,8 @@ function ImageURL(id, version = "Primary", params = {})
 end function
 
 function UserImageURL(id, params = {})
+    if not isValid(id) then return ""
+
     ' set defaults
     if params.maxHeight = invalid
         params.append({ "maxHeight": "300" })
@@ -67,6 +69,5 @@ function UserImageURL(id, params = {})
         params.append({ "quality": "90" })
     end if
 
-    url = Substitute("Users/{0}/Images/Primary", id)
-    return buildURL(url, params)
+    return buildURL(`Users/${id}/Images/Primary`, params)
 end function
diff --git a/source/static/whatsNew/1.0.10.json b/source/static/whatsNew/1.0.10.json
@@ -10,5 +10,13 @@
   {
     "description": "Don't use web setting for Live TV view",
     "author": "1hitsong"
+  },
+  {
+    "description": "Begin reworking LiveTV design & code",
+    "author": "1hitsong"
+  },
+  {
+    "description": "Fix login crash",
+    "author": "1hitsong"
   }
 ]