fix: video not publishing on sfu migration

100mslive · Jan 14, 2025 · 40df8eb · 40df8eb
1 parent 0d5d9b3
commit 40df8eb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 16 deletions.
diff --git a/packages/hms-video-store/src/media/tracks/HMSLocalAudioTrack.ts b/packages/hms-video-store/src/media/tracks/HMSLocalAudioTrack.ts
@@ -72,14 +72,12 @@ export class HMSLocalAudioTrack extends HMSAudioTrack {
   }
 
   clone(stream: HMSLocalStream) {
-    const track = new HMSLocalAudioTrack(
-      stream,
-      this.nativeTrack.clone(),
-      this.source!,
-      this.eventBus,
-      this.settings,
-      this.room,
-    );
+    const clonedTrack = this.nativeTrack.clone();
+    /**
+     * stream only becomes active when the track is added to it.
+     */
+    stream.nativeStream.addTrack(clonedTrack);
+    const track = new HMSLocalAudioTrack(stream, clonedTrack, this.source!, this.eventBus, this.settings, this.room);
     track.peerId = this.peerId;
 
     if (this.pluginsManager.pluginsMap.size > 0) {

diff --git a/packages/hms-video-store/src/media/tracks/HMSLocalVideoTrack.ts b/packages/hms-video-store/src/media/tracks/HMSLocalVideoTrack.ts
@@ -93,14 +93,13 @@ export class HMSLocalVideoTrack extends HMSVideoTrack {
   }
 
   clone(stream: HMSLocalStream) {
-    const track = new HMSLocalVideoTrack(
-      stream,
-      this.nativeTrack.clone(),
-      this.source!,
-      this.eventBus,
-      this.settings,
-      this.room,
-    );
+    const clonedTrack = this.nativeTrack.clone();
+    /**
+     * stream only becomes active when the track is added to it. If this is not added, after sfu migration, in non-simulcast case, the video will not be
+     * published to the server
+     */
+    stream.nativeStream.addTrack(clonedTrack);
+    const track = new HMSLocalVideoTrack(stream, clonedTrack, this.source!, this.eventBus, this.settings, this.room);
     track.peerId = this.peerId;
 
     if (this.pluginsManager.pluginsMap.size > 0) {