Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename chainID into chainId #621

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Rename chainID into chainId #621

wants to merge 1 commit into from

Conversation

xiam
Copy link
Contributor

@xiam xiam commented Dec 6, 2024

This PR will rename chainID properties into chainId, which is the preferred spelling.

@xiam xiam requested a review from a team as a code owner December 6, 2024 16:26
@pkieltyka
Copy link
Member

we cannot merge this, as it will break too many apps.. but we should figure out some day how we can do it

pkieltyka
pkieltyka requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@pkieltyka pkieltyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break too many apps

@pkieltyka pkieltyka marked this pull request as draft December 6, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkieltyka pkieltyka pkieltyka requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiam @pkieltyka