WIP - Transaction status modal and transaction flow #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al when it's done
| @@ -531,7 +547,7 @@ export class TransactionMachine { | |||
| } else if (step.id === StepType.tokenApproval) { | |||
| //TODO: Add some sort ofs callback heres | |||
| const hash = await this.executeTransaction(step); | |||
There was a problem hiding this comment.
This will cause the TransactionStatusModal to be shown on token approvals, I dont think that is what we want.
Should we have a prop to disable it?
* implement listenApprovalReceipt, * implement approve,
For some cases, fetching them doesn't work because they expect user to input some price or something. For instance, selling modal doesn't require a user input, fetching steps on init works good.
…nce steps are fetched on init for create listing modal
packages/sdk/src/react/_internal/transaction-machine/execute-transaction.ts
Outdated
Show resolved
Hide resolved
w1that
changed the title
w1that
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the network is busy or there are some other transactions to do before,
waitForTransactionReceiptfrompublicClientthrows a related error and it makes us more comfortable to see if it isFailedor justTimed out. Some extra copies are added to let user know what's going on.Transaction machine refactors in progress...