support go-onchain-credential-adapter #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om go-iden3-core library.
…esolverRegistry instead of custom code
…, but that accepts configuration and registers custom DID methods.
vmidyllic
approved these changes
Feb 26, 2024
olomix
requested changes
Feb 26, 2024
| @@ -861,6 +861,56 @@ func PLGNCacheCredentials(in *C.char, cfg *C.char, status **C.PLGNStatus) bool { | |||
| return true | |||
| } | |||
|
|
|||
| //export PLGNW3CCredentialFromOnchainHex | |||
| func PLGNW3CCredentialFromOnchainHex(jsonResponse **C.char, in *C.char, | |||
There was a problem hiding this comment.
Could you add a documentation to this function?
| return nil, | ||
| fmt.Errorf("failed to connect to ethereum: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| defer ethcli.Close() | |
onchain_adapter_test.go
Outdated
Comment on lines
35
to
39
| outBytes, err := json.Marshal(out) | ||
| require.NoError(t, err) | ||
| var actualOutCredential *verifiable.W3CCredential | ||
| err = json.Unmarshal(outBytes, &actualOutCredential) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Suggested change
| outBytes, err := json.Marshal(out) | |
| require.NoError(t, err) | |
| var actualOutCredential *verifiable.W3CCredential | |
| err = json.Unmarshal(outBytes, &actualOutCredential) | |
| require.NoError(t, err) | |
| var actualOutCredential *verifiable.W3CCredential | |
| err = remarshalObj(&actualOutCredential, out) | |
| require.NoError(t, err) |
onchain_adapter_test.go
Outdated
| require.Equal(t, wantOutCredential, actualOutCredential) | ||
| } | ||
|
|
||
| removeIdFromEthBody := func(body []byte) []byte { |
There was a problem hiding this comment.
It's the same function as in TestPrepareInputs. Maybe it would be better to move it to an outer scope and use the same function in both places?
olomix
approved these changes
Feb 26, 2024
cmd/polygonid/polygonid.go
Outdated
| @@ -861,6 +861,16 @@ func PLGNCacheCredentials(in *C.char, cfg *C.char, status **C.PLGNStatus) bool { | |||
| return true | |||
| } | |||
|
|
|||
| // PLGNW3CCredentialFromOnchainHex returns a verifiable credential from an onchain data hex string. | |||
| // | |||
| // Sample configuration: | |||
There was a problem hiding this comment.
it's an input, not a configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.