Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/incaberry #226

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Feature/incaberry #226

merged 8 commits into from
Nov 22, 2023

Conversation

krlosMata
Copy link
Contributor

  • update to fork.6

zkronos73 and others added 5 commits October 20, 2023 16:19
@zkronos73
Update main.yml
c5b96ae
@zkronos73 @RogerTaule
fix/ecrecover alias diffequals sqrt (#3)
a4006af 
* extra arith feature alias-free on p3 and p1 and p2 differents verification

* fix some comments and simplify

* added some comments

* Modifying final.circom to use lessthangl.circom file

* update package versions

* update package json

* fix bug on sm_arith and add more tests cases

* Update main.yml

---------

Co-authored-by: RogerTaule <[email protected]>
@krlosMata
update inputs incaberry
a88dbc0
@krlosMata
Merge pull request #9 from 0xPolygonHermez/feature/update-inputs-inca…
928ece2 
…berry

update inputs incaberry
@krlosMata
update zkevm-rom tag
6889c4d
@cla-bot cla-bot bot added the cla-signed label Nov 20, 2023
@krlosMata krlosMata force-pushed the feature/incaberry branch 2 times, most recently from d936e6f to 5ff55a1 Compare November 20, 2023 15:12
ignasirv
ignasirv approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ignasirv ignasirv force-pushed the feature/incaberry branch 2 times, most recently from a9b5bbd to f188007 Compare November 20, 2023 16:27
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@krlosMata krlosMata merged commit e083561 into develop Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkronos73 zkronos73 zkronos73 approved these changes

@ignasirv ignasirv ignasirv approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @ignasirv @zkronos73