Use unchecked in DepositContract.sol
#366
Draft
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a typo on documentation
Use unchecked in the _deposit function to skip Solidity's built-in overflow checks for the ++depositCount operation since the preceding condition (if (depositCount >= _MAX_DEPOSIT_COUNT)) already ensures that an overflow is impossible. This eliminates unnecessary runtime checks, reducing gas costs.
|
We require contributors/corporates @floor-licker to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
|
Hey ^^ this is a nice optimization. We might add it into future iterations of the code. |
|
@invocamanman Sounds good, I just changed base to the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
uncheckedin the_depositfunction to skip Solidity's built-in overflow checks for the++depositCountoperation since the preceding condition(if (depositCount >= _MAX_DEPOSIT_COUNT))already ensures that an overflow is impossible. This eliminates unnecessary runtime checks, reducing gas costs.