Feature/localbridgesync #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcastellm
reviewed
Jul 2, 2024
vcastellm
reviewed
Jul 2, 2024
| case <-ctx.Done(): | ||
| close(downloadedCh) | ||
| return | ||
| default: |
There was a problem hiding this comment.
Would it make sense to introduce the polling frequency parameter and use it here (namely declare some ticker here and periodically fetch and notify about the new blocks)?
There was a problem hiding this comment.
the idea is to don't have frequency, but rather go until the end (tip of the network) and if reached wait for new blocks
arnaubennassar
force-pushed
the
feature/localbridgesync
branch
from
7caed89
to
a17868b
Compare
| } | ||
|
|
||
| func New(ctx context.Context) (*ReorgDetector, error) { | ||
| r := &ReorgDetector{} |
There was a problem hiding this comment.
Reminder: don't forget to provide the ethclient.Client reference through a constructor.
vcastellm
reviewed
Jul 15, 2024
vcastellm
reviewed
Jul 15, 2024
vcastellm
reviewed
Jul 15, 2024
vcastellm
reviewed
Jul 15, 2024
|
arnaubennassar
requested review from
joanestebanr,
Stefan-Ethernal and
vcastellm
vcastellm
approved these changes
Jul 16, 2024
| ) | ||
|
|
||
| var ( | ||
| bridgeEventSignature = crypto.Keccak256Hash([]byte("BridgeEvent(uint8,uint32,address,uint32,address,uint256,bytes,uint32)")) |
There was a problem hiding this comment.
Aren't this declared on cdk-contracts-tooling repo?
| } | ||
|
|
||
| func New(ctx context.Context) (*ReorgDetector, error) { | ||
| r := &ReorgDetector{} |
| for currentBlock > lastBlockFromClient { | ||
| lastBlockFromClient, err = r.ethClient.BlockNumber(ctx) | ||
| if err != nil { | ||
| // TODO: handle error |
| } | ||
| block, err := r.ethClient.HeaderByNumber(ctx, big.NewInt(int64(currentBlock))) | ||
| if err != nil { | ||
| // TODO: handle error |
joanestebanr
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
localbridgesyncer. Please do not review thereorgdetectoras it's left as a PoC